Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1846)

Unified Diff: content/renderer/web_ui_mojo.h

Issue 1137533002: MainFrameObserver is inline owned, so it shouldn't be freed by OnDestruct (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments by sky@. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/web_ui_mojo.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/web_ui_mojo.h
diff --git a/content/renderer/web_ui_mojo.h b/content/renderer/web_ui_mojo.h
index f7179ef5d816447e1f314b56cdb14966d7e5fe53..769722ece0170b9e89081e4f16b54728ed37bdd9 100644
--- a/content/renderer/web_ui_mojo.h
+++ b/content/renderer/web_ui_mojo.h
@@ -40,6 +40,11 @@ class WebUIMojo
void WillReleaseScriptContext(v8::Local<v8::Context> context,
int world_id) override;
void DidFinishDocumentLoad() override;
+ // MainFrameObserver is inline owned by WebUIMojo and should not be
+ // destroyed when the main RenderFrame is deleted. Overriding the
+ // OnDestruct method allows this object to remain alive and be cleaned
+ // up as part of WebUIMojo deletion.
+ void OnDestruct() override;
private:
WebUIMojo* web_ui_mojo_;
« no previous file with comments | « no previous file | content/renderer/web_ui_mojo.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698