Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1959)

Unified Diff: content/renderer/web_ui_mojo.h

Issue 1137533002: MainFrameObserver is inline owned, so it shouldn't be freed by OnDestruct (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/web_ui_mojo.h
diff --git a/content/renderer/web_ui_mojo.h b/content/renderer/web_ui_mojo.h
index f7179ef5d816447e1f314b56cdb14966d7e5fe53..bfc4eb50575e03ddb437b86c8409b26a14ebcc64 100644
--- a/content/renderer/web_ui_mojo.h
+++ b/content/renderer/web_ui_mojo.h
@@ -40,6 +40,7 @@ class WebUIMojo
void WillReleaseScriptContext(v8::Local<v8::Context> context,
int world_id) override;
void DidFinishDocumentLoad() override;
+ void OnDestruct() override {}
sky 2015/05/08 16:28:38 Style guide says we shouldn't inline this, also, i
nasko 2015/05/08 17:28:50 Done.
private:
WebUIMojo* web_ui_mojo_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698