Autofill: Add WalletIntegrationAvailable() to components.

Autofill: Add WalletIntegrationAvailable() to components.

Move logic of WalletIntegrationAvailableForProfile() function to
components dir.

BUG=482268
Committed: https://crrev.com/d81963c3cea4912a9cdd9decc5910749374f0701
Cr-Commit-Position: refs/heads/master@{#328969}

[bondd, 2015-05-07 19:16:45]

bondd@chromium.org changed reviewers:
+ estade@chromium.org

[bondd, 2015-05-07 19:16:45]

bondd@chromium.org changed required reviewers:
+ estade@chromium.org

[Evan Stade, 2015-05-07 19:59:47]

lgtm with nits

https://codereview.chromium.org/1137513002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/options_util.cc (right):

https://codereview.chromium.org/1137513002/diff/1/components/autofill/core/br...
components/autofill/core/browser/options_util.cc:15: PrefService* pref_service,
this should be const ref

https://codereview.chromium.org/1137513002/diff/1/components/autofill/core/br...
components/autofill/core/browser/options_util.cc:16: PersonalDataManager*
personal_data_manager) {
this should be const ref

https://codereview.chromium.org/1137513002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/options_util.h (right):

https://codereview.chromium.org/1137513002/diff/1/components/autofill/core/br...
components/autofill/core/browser/options_util.h:14: namespace autofill {
nit: \n

[bondd, 2015-05-07 21:19:24]

Thanks. Please see comment at bottom re: DCHECK.

https://codereview.chromium.org/1137513002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/options_util.cc (right):

https://codereview.chromium.org/1137513002/diff/1/components/autofill/core/br...
components/autofill/core/browser/options_util.cc:15: PrefService* pref_service,
On 2015/05/07 19:59:46, Evan Stade wrote:
> this should be const ref

Done.

https://codereview.chromium.org/1137513002/diff/1/components/autofill/core/br...
components/autofill/core/browser/options_util.cc:16: PersonalDataManager*
personal_data_manager) {
On 2015/05/07 19:59:46, Evan Stade wrote:
> this should be const ref

Done.

https://codereview.chromium.org/1137513002/diff/1/components/autofill/core/br...
File components/autofill/core/browser/options_util.h (right):

https://codereview.chromium.org/1137513002/diff/1/components/autofill/core/br...
components/autofill/core/browser/options_util.h:14: namespace autofill {
On 2015/05/07 19:59:46, Evan Stade wrote:
> nit: \n

Done.

https://codereview.chromium.org/1137513002/diff/20001/chrome/browser/autofill...
File chrome/browser/autofill/options_util.cc (right):

https://codereview.chromium.org/1137513002/diff/20001/chrome/browser/autofill...
chrome/browser/autofill/options_util.cc:18:
*PersonalDataManagerFactory::GetForProfile(profile));
LMK if you want me to DCHECK prefs and profile before dereferencing. In
codesearch it looks like a lot of other code assumes they're good without
DCHECKing, and as the code exists now GetPrefs() and GetForProfile() will both
always return valid data AFAICT. If I don't hear anything by the time the
trybots are done I'll go ahead and check the CQ bit.

[Evan Stade, 2015-05-07 21:23:02]

https://codereview.chromium.org/1137513002/diff/20001/chrome/browser/autofill...
File chrome/browser/autofill/options_util.cc (right):

https://codereview.chromium.org/1137513002/diff/20001/chrome/browser/autofill...
chrome/browser/autofill/options_util.cc:18:
*PersonalDataManagerFactory::GetForProfile(profile));
On 2015/05/07 21:19:24, bondd wrote:
> LMK if you want me to DCHECK prefs and profile before dereferencing. In
> codesearch it looks like a lot of other code assumes they're good without
> DCHECKing, and as the code exists now GetPrefs() and GetForProfile() will both
> always return valid data AFAICT. If I don't hear anything by the time the
> trybots are done I'll go ahead and check the CQ bit.

DCHECK is just documentation that you expect something to be valid. You
shouldn't DCHECK right before deref'ing because deref'ing provides that
documentation. (The DCHECK in the version where you were passing a pointer is
also explicitly discouraged in the Chrome style guide.)

[bondd, 2015-05-07 22:40:59]

The CQ bit was checked by bondd@chromium.org

[bondd, 2015-05-07 22:41:00]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/1137513002/#ps20001
(title: "Change pointer params to const ref. Add newline.")

[commit-bot: I haz the power, 2015-05-07 22:42:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137513002/20001

[commit-bot: I haz the power, 2015-05-07 22:52:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 22:52:36]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[bondd, 2015-05-08 01:16:04]

bondd@chromium.org changed reviewers:
+ maniscalco@chromium.org

[bondd, 2015-05-08 01:16:04]

bondd@chromium.org changed required reviewers:
+ maniscalco@chromium.org

[bondd, 2015-05-08 01:16:04]

Hi maniscalco@,
I am getting the following error from chrome_presubmit:
Missing LGTM from OWNERS of dependencies added to DEPS:
    '+components/sync_driver',

If you could review the DEPS change for me that would be great. Normally I would
ask sdefresnse@ to review as he is an OWNER of components/ and has reviewed
other related CLs for me, but he is OOO until Monday.

If I have misunderstood what the error message is asking for then my apologies.
:)

Thanks
-Dave

[maniscalco, 2015-05-08 15:23:45]

On 2015/05/08 01:16:04, bondd wrote:
> Hi maniscalco@,
> I am getting the following error from chrome_presubmit:
> Missing LGTM from OWNERS of dependencies added to DEPS:
>     '+components/sync_driver',
> 
> If you could review the DEPS change for me that would be great. Normally I
would
> ask sdefresnse@ to review as he is an OWNER of components/ and has reviewed
> other related CLs for me, but he is OOO until Monday.
> 
> If I have misunderstood what the error message is asking for then my
apologies.
> :)
> 
> Thanks
> -Dave

components/autofill/core/browser/DEPS LGTM!

[bondd, 2015-05-08 16:40:17]

The CQ bit was checked by bondd@chromium.org

[commit-bot: I haz the power, 2015-05-08 16:40:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137513002/20001

[commit-bot: I haz the power, 2015-05-08 16:46:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-08 16:47:08]

Patchset 2 (id:??) landed as
https://crrev.com/d81963c3cea4912a9cdd9decc5910749374f0701
Cr-Commit-Position: refs/heads/master@{#328969}

[bondd, 2015-05-08 17:14:57]

On 2015/05/08 15:23:45, maniscalco wrote:
> On 2015/05/08 01:16:04, bondd wrote:
> > Hi maniscalco@,
> > I am getting the following error from chrome_presubmit:
> > Missing LGTM from OWNERS of dependencies added to DEPS:
> >     '+components/sync_driver',
> > 
> > If you could review the DEPS change for me that would be great. Normally I
> would
> > ask sdefresnse@ to review as he is an OWNER of components/ and has reviewed
> > other related CLs for me, but he is OOO until Monday.
> > 
> > If I have misunderstood what the error message is asking for then my
> apologies.
> > :)
> > 
> > Thanks
> > -Dave
> 
> components/autofill/core/browser/DEPS LGTM!

Great, thanks a lot Nick. Much appreciated. :)

[Evan Stade, 2015-05-11 18:00:38]

https://codereview.chromium.org/1137513002/diff/20001/chrome/browser/autofill...
File chrome/browser/autofill/options_util.cc (left):

https://codereview.chromium.org/1137513002/diff/20001/chrome/browser/autofill...
chrome/browser/autofill/options_util.cc:31: if
(!profile->GetPrefs()->GetBoolean(prefs::kAutofillWalletImportEnabled))
you inverted this check