Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3267)

Unified Diff: chrome/browser/extensions/suspicious_extension_bubble_controller.cc

Issue 1137503006: [Extensions] Polish the suspicious extension bubble (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Finnur's Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/suspicious_extension_bubble_controller.cc
diff --git a/chrome/browser/extensions/suspicious_extension_bubble_controller.cc b/chrome/browser/extensions/suspicious_extension_bubble_controller.cc
index 94d189fe350ca6de1171cec56fedc6482083e5a2..3f045e3dec4cccf4fb9f78646e7de70679dc588d 100644
--- a/chrome/browser/extensions/suspicious_extension_bubble_controller.cc
+++ b/chrome/browser/extensions/suspicious_extension_bubble_controller.cc
@@ -46,7 +46,8 @@ class SuspiciousExtensionBubbleDelegate
ExtensionMessageBubbleController::BubbleAction user_action) override;
void PerformAction(const extensions::ExtensionIdList& list) override;
base::string16 GetTitle() const override;
- base::string16 GetMessageBody(bool anchored_to_browser_action) const override;
+ base::string16 GetMessageBody(bool anchored_to_browser_action,
+ int extension_count) const override;
base::string16 GetOverflowText(
const base::string16& overflow_count) const override;
GURL GetLearnMoreUrl() const override;
@@ -101,9 +102,13 @@ base::string16 SuspiciousExtensionBubbleDelegate::GetTitle() const {
}
base::string16 SuspiciousExtensionBubbleDelegate::GetMessageBody(
- bool anchored_to_browser_action) const {
- return l10n_util::GetStringFUTF16(IDS_EXTENSIONS_UNSUPPORTED_DISABLED_BODY,
- l10n_util::GetStringUTF16(IDS_EXTENSION_WEB_STORE_TITLE));
+ bool anchored_to_browser_action,
+ int extension_count) const {
+ int message_id = extension_count == 1 ?
+ IDS_EXTENSIONS_SINGLE_UNSUPPORTED_DISABLED_BODY :
+ IDS_EXTENSIONS_MULTIPLE_UNSUPPORTED_DISABLED_BODY;
+ return l10n_util::GetStringFUTF16(
+ message_id, l10n_util::GetStringUTF16(IDS_EXTENSION_WEB_STORE_TITLE));
}
base::string16 SuspiciousExtensionBubbleDelegate::GetOverflowText(

Powered by Google App Engine
This is Rietveld 408576698