Add launcherPage.hide() API.

Add launcherPage.hide() API.

This CL adds a launcherPage.hide() API which can be used by custom
launcher pages to implement custom hiding behavior. The API only works
if the custom launcher page is showing and does nothing otherwise.

BUG=481712
Committed: https://crrev.com/a43eb7176f8f602c2e94d137a401490fceb65f77
Cr-Commit-Position: refs/heads/master@{#330065}

[calamity, 2015-05-14 06:30:08]

Patchset #1 (id:1) has been deleted

[calamity, 2015-05-14 06:30:25]

The CQ bit was checked by calamity@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-14 06:30:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137503005/20001

[calamity, 2015-05-14 06:30:36]

calamity@chromium.org changed reviewers:
+ mgiuca@chromium.org

[commit-bot: I haz the power, 2015-05-14 06:33:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 06:33:38]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[Matt Giuca, 2015-05-14 06:56:02]

https://codereview.chromium.org/1137503005/diff/20001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/app_list_service.h (right):

https://codereview.chromium.org/1137503005/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/app_list_service.h:105: virtual void
HideLauncherPageIfShowing() = 0;
I think the "IfShowing" is not necessary (it's sort of an obvious consequence
that if the launcher page is hidden, hide can't do anything). Worth documenting,
but unnecessary in the name.

https://codereview.chromium.org/1137503005/diff/20001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/app_list_service_views.cc (right):

https://codereview.chromium.org/1137503005/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/app_list_service_views.cc:60:
app_list::AppListModel::STATE_CUSTOM_LAUNCHER_PAGE)) {
if (!contents_view->blahblahblah....)
  return;

https://codereview.chromium.org/1137503005/diff/20001/chrome/browser/ui/ash/a...
File chrome/browser/ui/ash/app_list/app_list_service_ash.cc (right):

https://codereview.chromium.org/1137503005/diff/20001/chrome/browser/ui/ash/a...
chrome/browser/ui/ash/app_list/app_list_service_ash.cc:103:
app_list::AppListModel::STATE_CUSTOM_LAUNCHER_PAGE)) {
Same as in views.

[calamity, 2015-05-14 08:11:27]

calamity@chromium.org changed reviewers:
+ benwells@chromium.org

[calamity, 2015-05-14 08:11:28]

+benwells for extensions/apps OWNERS

https://codereview.chromium.org/1137503005/diff/20001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/app_list_service.h (right):

https://codereview.chromium.org/1137503005/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/app_list_service.h:105: virtual void
HideLauncherPageIfShowing() = 0;
On 2015/05/14 06:56:02, Matt Giuca wrote:
> I think the "IfShowing" is not necessary (it's sort of an obvious consequence
> that if the launcher page is hidden, hide can't do anything). Worth
documenting,
> but unnecessary in the name.

Done. Also changed to Hide_Custom_LauncherPage() for consistency.

https://codereview.chromium.org/1137503005/diff/20001/chrome/browser/ui/app_l...
File chrome/browser/ui/app_list/app_list_service_views.cc (right):

https://codereview.chromium.org/1137503005/diff/20001/chrome/browser/ui/app_l...
chrome/browser/ui/app_list/app_list_service_views.cc:60:
app_list::AppListModel::STATE_CUSTOM_LAUNCHER_PAGE)) {
On 2015/05/14 06:56:02, Matt Giuca wrote:
> if (!contents_view->blahblahblah....)
>   return;

Leaving this, as discussed.

https://codereview.chromium.org/1137503005/diff/20001/chrome/browser/ui/ash/a...
File chrome/browser/ui/ash/app_list/app_list_service_ash.cc (right):

https://codereview.chromium.org/1137503005/diff/20001/chrome/browser/ui/ash/a...
chrome/browser/ui/ash/app_list/app_list_service_ash.cc:103:
app_list::AppListModel::STATE_CUSTOM_LAUNCHER_PAGE)) {
On 2015/05/14 06:56:02, Matt Giuca wrote:
> Same as in views.

Leaving it, as discussed.

[calamity, 2015-05-14 08:17:14]

calamity@chromium.org changed reviewers:
+ asvitkine@chromium.org

[calamity, 2015-05-14 08:17:15]

+asvitkine for histograms OWNERS.

[Matt Giuca, 2015-05-14 08:20:00]

lgtm

[Alexei Svitkine (slow), 2015-05-14 14:52:13]

lgtm

[benwells, 2015-05-15 04:13:40]

lgtm

[calamity, 2015-05-15 05:25:06]

The CQ bit was checked by calamity@chromium.org

[calamity, 2015-05-15 05:25:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org, asvitkine@chromium.org, mgiuca@chromium.org
Link to the patchset: https://codereview.chromium.org/1137503005/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2015-05-15 05:25:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137503005/80001

[commit-bot: I haz the power, 2015-05-15 05:33:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-15 05:33:56]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[calamity, 2015-05-15 05:50:52]

The CQ bit was checked by calamity@chromium.org

[calamity, 2015-05-15 05:50:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org, asvitkine@chromium.org, mgiuca@chromium.org
Link to the patchset: https://codereview.chromium.org/1137503005/#ps100001
(title: "fix test")

[commit-bot: I haz the power, 2015-05-15 05:51:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137503005/100001

[commit-bot: I haz the power, 2015-05-15 05:59:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-15 06:00:01]

Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[calamity, 2015-05-15 07:03:53]

The CQ bit was checked by calamity@chromium.org

[calamity, 2015-05-15 07:03:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org, asvitkine@chromium.org, mgiuca@chromium.org
Link to the patchset: https://codereview.chromium.org/1137503005/#ps120001
(title: "fix mobile")

[commit-bot: I haz the power, 2015-05-15 07:04:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137503005/120001

[commit-bot: I haz the power, 2015-05-15 08:39:29]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2015-05-15 08:40:18]

Patchset 6 (id:??) landed as
https://crrev.com/a43eb7176f8f602c2e94d137a401490fceb65f77
Cr-Commit-Position: refs/heads/master@{#330065}