Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1137473002: Fix the build with snapshot=external (Closed)

Created:
5 years, 7 months ago by domenic
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix the build with snapshot=external R=jochen@chromium.org BUG= Committed: https://crrev.com/0d1e35ab432505170d39846c42902cd7cfd08608 Cr-Commit-Position: refs/heads/master@{#28304}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/startup-data-util.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
domenic
5 years, 7 months ago (2015-05-07 17:35:56 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-07 17:40:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137473002/1
5 years, 7 months ago (2015-05-07 17:41:33 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 18:18:08 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 18:18:20 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d1e35ab432505170d39846c42902cd7cfd08608
Cr-Commit-Position: refs/heads/master@{#28304}

Powered by Google App Engine
This is Rietveld 408576698