Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: google_apis/gcm/engine/registration_request.h

Issue 1137463003: Support getting and deleting token for Instance ID. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More changes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/registration_request.h
diff --git a/google_apis/gcm/engine/registration_request.h b/google_apis/gcm/engine/registration_request.h
index 1f707b9dd9ee276fd6ddb34609f8f4ddc9fb9595..fb1f28c781d2a6fc482a39460b209d6cc0e0542c 100644
--- a/google_apis/gcm/engine/registration_request.h
+++ b/google_apis/gcm/engine/registration_request.h
@@ -59,14 +59,12 @@ class GCM_EXPORT RegistrationRequest : public net::URLFetcherDelegate {
const std::string& registration_id)>
RegistrationCallback;
- // Details of the of the Registration Request. Only user's android ID and
- // its serial number are optional and can be set to 0. All other parameters
- // have to be specified to successfully complete the call.
+ // Defines the common info about a registration/token request. All parameters
+ // are mandatory.
struct GCM_EXPORT RequestInfo {
RequestInfo(uint64 android_id,
uint64 security_token,
- const std::string& app_id,
- const std::vector<std::string>& sender_ids);
+ const std::string& app_id);
~RequestInfo();
// Android ID of the device.
@@ -75,20 +73,28 @@ class GCM_EXPORT RegistrationRequest : public net::URLFetcherDelegate {
uint64 security_token;
// Application ID.
std::string app_id;
- // Certificate of the application.
- std::string cert;
- // List of IDs of senders. Allowed up to 100.
- std::vector<std::string> sender_ids;
+ };
+
+ // Encapsulates the custom logic that is needed to build and process the
+ // registration request.
+ class GCM_EXPORT CustomRequestHandler {
+ public:
+ CustomRequestHandler();
+ virtual ~CustomRequestHandler();
+
+ virtual void BuildRequestBody(std::string* body) = 0;
Nicolas Zea 2015/05/26 16:39:15 Comment describing what this method does and when
jianli 2015/05/26 20:49:39 Done.
};
RegistrationRequest(
const GURL& registration_url,
const RequestInfo& request_info,
+ scoped_ptr<CustomRequestHandler> custom_request_handler,
const net::BackoffEntry::Policy& backoff_policy,
const RegistrationCallback& callback,
int max_retry_count,
scoped_refptr<net::URLRequestContextGetter> request_context_getter,
- GCMStatsRecorder* recorder);
+ GCMStatsRecorder* recorder,
+ const std::string& source_to_record);
~RegistrationRequest() override;
void Start();
@@ -101,12 +107,16 @@ class GCM_EXPORT RegistrationRequest : public net::URLFetcherDelegate {
// failure, when |update_backoff| is true.
void RetryWithBackoff(bool update_backoff);
+ void BuildRequestHeaders(std::string* extra_headers);
+ void BuildRequestBody(std::string* body);
+
// Parse the response returned by the URL fetcher into token, and returns the
// status.
Status ParseResponse(const net::URLFetcher* source, std::string* token);
RegistrationCallback callback_;
RequestInfo request_info_;
+ scoped_ptr<CustomRequestHandler> custom_request_handler_;
GURL registration_url_;
net::BackoffEntry backoff_entry_;
@@ -117,6 +127,7 @@ class GCM_EXPORT RegistrationRequest : public net::URLFetcherDelegate {
// Recorder that records GCM activities for debugging purpose. Not owned.
GCMStatsRecorder* recorder_;
+ std::string source_to_record_;
base::WeakPtrFactory<RegistrationRequest> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698