Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: base/message_loop/message_pump_default.cc

Issue 1137453006: Treat a delay of under 1 millisecond in MessagePumpDefault as a signal that the corresponding delay… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix build error Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/message_loop/message_pump_default.h" 5 #include "base/message_loop/message_pump_default.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/threading/thread_restrictions.h" 8 #include "base/threading/thread_restrictions.h"
9 9
10 #if defined(OS_MACOSX) 10 #if defined(OS_MACOSX)
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 break; 45 break;
46 46
47 if (did_work) 47 if (did_work)
48 continue; 48 continue;
49 49
50 ThreadRestrictions::ScopedAllowWait allow_wait; 50 ThreadRestrictions::ScopedAllowWait allow_wait;
51 if (delayed_work_time_.is_null()) { 51 if (delayed_work_time_.is_null()) {
52 event_.Wait(); 52 event_.Wait();
53 } else { 53 } else {
54 TimeDelta delay = delayed_work_time_ - TimeTicks::Now(); 54 TimeDelta delay = delayed_work_time_ - TimeTicks::Now();
55 if (delay > TimeDelta()) { 55 // If the delay is under 1 ms we need to execute the task right away.
56 if (delay.InMilliseconds() >= 1) {
56 event_.TimedWait(delay); 57 event_.TimedWait(delay);
57 } else { 58 } else {
58 // It looks like delayed_work_time_ indicates a time in the past, so we 59 // It looks like delayed_work_time_ indicates a time in the past, so we
59 // need to call DoDelayedWork now. 60 // need to call DoDelayedWork now.
60 delayed_work_time_ = TimeTicks(); 61 delayed_work_time_ = TimeTicks();
61 } 62 }
62 } 63 }
63 // Since event_ is auto-reset, we don't need to do anything special here 64 // Since event_ is auto-reset, we don't need to do anything special here
64 // other than service each delegate method. 65 // other than service each delegate method.
65 } 66 }
(...skipping 13 matching lines...) Expand all
79 80
80 void MessagePumpDefault::ScheduleDelayedWork( 81 void MessagePumpDefault::ScheduleDelayedWork(
81 const TimeTicks& delayed_work_time) { 82 const TimeTicks& delayed_work_time) {
82 // We know that we can't be blocked on Wait right now since this method can 83 // We know that we can't be blocked on Wait right now since this method can
83 // only be called on the same thread as Run, so we only need to update our 84 // only be called on the same thread as Run, so we only need to update our
84 // record of how long to sleep when we do sleep. 85 // record of how long to sleep when we do sleep.
85 delayed_work_time_ = delayed_work_time; 86 delayed_work_time_ = delayed_work_time;
86 } 87 }
87 88
88 } // namespace base 89 } // namespace base
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698