content/common/mac/io_surface_manager_token.h - Issue 1137453002: content: Pass IOSurface references using Mach IPC.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/common/mac/io_surface_manager_token.h

Issue 1137453002: content: Pass IOSurface references using Mach IPC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rsesek's review Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CONTENT_COMMON_MAC_IO_SURFACE_MANAGER_TOKEN_H_

	6 #define CONTENT_COMMON_MAC_IO_SURFACE_MANAGER_TOKEN_H_
	Robert Sesek 2015/05/28 18:25:11 I'm not sure this needs its own file. Can it go in I'm not sure this needs its own file. Can it go in io_surface_manager.h or io_surface_manager_messages.h ? reveman 2015/05/29 00:09:02 I prefer a separate file. io_surface_manager.h is Show quoted text On 2015/05/28 at 18:25:11, Robert Sesek wrote: > I'm not sure this needs its own file. Can it go in io_surface_manager.h or io_surface_manager_messages.h ? I prefer a separate file. io_surface_manager.h is meant for clients of the IOSurfaceManager interface. The token doesn't belong in that file as it's an implementation detail and not a requirement to implement that interface. I could move it to io_surface_manager_messages.h but then files such as render_process_host_impl.h and child_process_messages.h which only care about the token would have to include that file even though the definition of Mach messages is not something the code in those files should be aware of.
	7

	8 #include "gpu/command_buffer/common/mailbox.h"

	9

	10 namespace content {

	11

	12 using IOSurfaceManagerToken = gpu::Mailbox;

	13

	14 } // namespace content

	15

	16 #endif // CONTENT_COMMON_MAC_IO_SURFACE_MANAGER_TOKEN_H_

OLD	NEW