build/config/BUILD.gn - Issue 1137443003: Fix the build metadata definition in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/BUILD.gn

Issue 1137443003: Fix the build metadata definition in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/BUILD.gn

diff --git a/build/config/BUILD.gn b/build/config/BUILD.gn

index 1bd666bd24cf4ba09239420e5c109aee50126089..2427b72afd920cf6b85a48d83f42a19fe5184bd4 100644

--- a/build/config/BUILD.gn

+++ b/build/config/BUILD.gn

@@ -24,7 +24,7 @@ declare_args() {

# TODO(maruel): This decision should be revisited because having an

# official deterministic build has high value too but MSVC toolset can't

# generate anything deterministic with WPO enabled AFAIK.

- dont_embed_build_metadata = is_official_build

+ dont_embed_build_metadata = !is_official_build

# Set to true to enable dcheck in Release builds.

dcheck_always_on = false

« no previous file with comments | « no previous file | no next file » | no next file with comments »