Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 1137443003: Fix the build metadata definition in the GN build. (Closed)

Created:
5 years, 7 months ago by brettw
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the build metadata definition in the GN build. The default value of the dont_embed_build_metadata in GN is swapped from the GYP build. Committed: https://crrev.com/be21e6fe0627b27d32a99c073e23b733d410b8a1 Cr-Commit-Position: refs/heads/master@{#328826}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
brettw
5 years, 7 months ago (2015-05-07 18:31:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137443003/1
5 years, 7 months ago (2015-05-07 18:33:55 UTC) #4
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-07 18:45:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137443003/1
5 years, 7 months ago (2015-05-07 19:07:56 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-07 21:01:41 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 21:02:59 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/be21e6fe0627b27d32a99c073e23b733d410b8a1
Cr-Commit-Position: refs/heads/master@{#328826}

Powered by Google App Engine
This is Rietveld 408576698