Encouraging ThreadTaskRunnerHandle usage in net/dns module

Encouraging ThreadTaskRunnerHandle usage in net/dns module

MessageLoopProxy is deprecated.
This basically does a search and replace of:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

MessageLoopProxy -> SingleThreadTaskRunner

BUG=391045
Committed: https://crrev.com/7c907f0a3aeb080691bfb1d74d3c46bc577e15cb
Cr-Commit-Position: refs/heads/master@{#331916}

[anujsharma, 2015-05-12 17:29:04]

anujk.sharma@samsung.com changed reviewers:
+ asanka@chromium.org

[anujsharma, 2015-05-12 17:29:05]

PTAL

[asanka, 2015-05-14 04:06:37]

https://codereview.chromium.org/1137433003/diff/1/net/dns/host_resolver_impl.cc
File net/dns/host_resolver_impl.cc (right):

https://codereview.chromium.org/1137433003/diff/1/net/dns/host_resolver_impl....
net/dns/host_resolver_impl.cc:908: scoped_refptr<base::SingleThreadTaskRunner>
origin_loop_;
Could you rename this to task_runner_ and document it as the task runner for the
origin thread?

[anujsharma, 2015-05-14 04:39:40]

Thanks asanka for your comments!!

I have made the changes.
PTAL

Thanks!!

https://codereview.chromium.org/1137433003/diff/1/net/dns/host_resolver_impl.cc
File net/dns/host_resolver_impl.cc (right):

https://codereview.chromium.org/1137433003/diff/1/net/dns/host_resolver_impl....
net/dns/host_resolver_impl.cc:908: scoped_refptr<base::SingleThreadTaskRunner>
origin_loop_;
On 2015/05/14 04:06:36, asanka wrote:
> Could you rename this to task_runner_ and document it as the task runner for
the
> origin thread?

Done.

[asanka, 2015-05-14 18:38:40]

https://codereview.chromium.org/1137433003/diff/20001/net/dns/host_resolver_i...
File net/dns/host_resolver_impl.cc (right):

https://codereview.chromium.org/1137433003/diff/20001/net/dns/host_resolver_i...
net/dns/host_resolver_impl.cc:916: // Used to post ourselves onto the task
runner thread.
.. on to the originating thread.

https://codereview.chromium.org/1137433003/diff/20001/net/dns/serial_worker.h
File net/dns/serial_worker.h (right):

https://codereview.chromium.org/1137433003/diff/20001/net/dns/serial_worker.h...
net/dns/serial_worker.h:64: base::SingleThreadTaskRunner* loop() { return
task_runner_.get(); }
Is this used? We should get rid of this if it isn't. Or rename it to
task_runner() if it is.

[anujsharma, 2015-05-20 13:13:16]

Hi Asanka,
updated the patch set, PTAL :)

-Thanks

https://codereview.chromium.org/1137433003/diff/20001/net/dns/host_resolver_i...
File net/dns/host_resolver_impl.cc (right):

https://codereview.chromium.org/1137433003/diff/20001/net/dns/host_resolver_i...
net/dns/host_resolver_impl.cc:916: // Used to post ourselves onto the task
runner thread.
On 2015/05/14 18:38:40, asanka wrote:
> .. on to the originating thread.

Done.

https://codereview.chromium.org/1137433003/diff/20001/net/dns/serial_worker.h
File net/dns/serial_worker.h (right):

https://codereview.chromium.org/1137433003/diff/20001/net/dns/serial_worker.h...
net/dns/serial_worker.h:64: base::SingleThreadTaskRunner* loop() { return
task_runner_.get(); }
Done..No reference found

[asanka, 2015-05-20 16:58:44]

lgtm

[anujsharma, 2015-05-21 02:42:42]

On 2015/05/20 16:58:44, asanka wrote:
> lgtm

Thanks asanka for lgtm.

[anujsharma, 2015-05-21 02:42:56]

The CQ bit was checked by anujk.sharma@samsung.com

[commit-bot: I haz the power, 2015-05-21 02:43:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137433003/40001

[commit-bot: I haz the power, 2015-05-21 03:21:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-21 03:21:28]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[anujsharma, 2015-05-28 03:28:35]

The CQ bit was checked by anujk.sharma@samsung.com to run a CQ dry run

[anujsharma, 2015-05-28 03:28:36]

The patchset sent to the CQ was uploaded after l-g-t-m from asanka@chromium.org
Link to the patchset: https://codereview.chromium.org/1137433003/#ps60001
(title: "Fixed build failure")

[commit-bot: I haz the power, 2015-05-28 03:29:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137433003/60001

[commit-bot: I haz the power, 2015-05-28 04:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-28 04:30:25]

Dry run: This issue passed the CQ dry run.

[anujsharma, 2015-05-28 06:11:17]

@asanka,

Sorry for late response, i was out of station.

loop() in "net/dns/serial_worker.h" is indirectly reffered in
"net\dns\dns_config_service_win.cc" and is affecting windows build after
removal.
That'swhy, we need to keep loop() in  "net/dns/serial_worker.h" file.

I have made the changes, PTAL.


Thanks!!

[asanka, 2015-05-28 14:38:15]

lgtm

[anujsharma, 2015-05-29 02:51:27]

On 2015/05/28 14:38:15, asanka wrote:
> lgtm

Thank you asanka for lgtm!!

[anujsharma, 2015-05-29 02:51:35]

The CQ bit was checked by anujk.sharma@samsung.com

[commit-bot: I haz the power, 2015-05-29 02:51:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137433003/60001

[commit-bot: I haz the power, 2015-05-29 02:55:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-29 02:56:45]

Patchset 4 (id:??) landed as
https://crrev.com/7c907f0a3aeb080691bfb1d74d3c46bc577e15cb
Cr-Commit-Position: refs/heads/master@{#331916}