Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Issue 1137423003: Add a GN.tmPreferences file so that command-/ works in sublime (Closed)

Created:
5 years, 7 months ago by eseidel
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke, tfarina
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a GN.tmPreferences file so that command-/ works in sublime Now sublime users can use command-/ to comment/uncomment lines in gn and gni files. R=dpranke@chromium.org Committed: https://crrev.com/bd03449ab9df2826b0402443d382be2363fc36dd Cr-Commit-Position: refs/heads/master@{#329927}

Patch Set 1 #

Patch Set 2 : Move to tm/ per dpranke's review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -101 lines) Patch
D tools/gn/misc/GN.tmLanguage View 1 chunk +0 lines, -102 lines 0 comments Download
A + tools/gn/misc/tm/GN.tmLanguage View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/gn/misc/tm/GN.tmPreferences View 1 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
eseidel
5 years, 7 months ago (2015-05-14 20:11:13 UTC) #1
Dirk Pranke
lgtm
5 years, 7 months ago (2015-05-14 20:17:59 UTC) #2
tfarina
not lgtm (yet). The author of tmPreferences file said in the review it didn't move ...
5 years, 7 months ago (2015-05-14 20:21:29 UTC) #4
tfarina
See https://codereview.chromium.org/1046933004/
5 years, 7 months ago (2015-05-14 20:22:24 UTC) #5
eseidel
I do not care one bit where these files go. Someone make a decision. The ...
5 years, 7 months ago (2015-05-14 20:24:06 UTC) #6
tfarina
I would be fine with: misc/GN.tmLanguage misc/GN.tmPreferences
5 years, 7 months ago (2015-05-14 20:25:58 UTC) #7
Dirk Pranke
Move it into tools/gn/misc/tm .
5 years, 7 months ago (2015-05-14 20:26:18 UTC) #8
eseidel
Done. Please lg and cq.
5 years, 7 months ago (2015-05-14 20:30:12 UTC) #9
tfarina
lgtm
5 years, 7 months ago (2015-05-14 20:30:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137423003/20001
5 years, 7 months ago (2015-05-14 20:33:28 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 20:44:14 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 20:45:49 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bd03449ab9df2826b0402443d382be2363fc36dd
Cr-Commit-Position: refs/heads/master@{#329927}

Powered by Google App Engine
This is Rietveld 408576698