Add style information to the snapshot node

content/browser/web_contents/web_contents_android.cc

Index: content/browser/web_contents/web_contents_android.cc
diff --git a/content/browser/web_contents/web_contents_android.cc b/content/browser/web_contents/web_contents_android.cc
index dc23623cf475b2867bf7d055483f239f88f0bd7c..2464e5c2cdbaec99063c68e3b74bc21b41b07511 100644
--- a/content/browser/web_contents/web_contents_android.cc
+++ b/content/browser/web_contents/web_contents_android.cc
@@ -60,11 +60,25 @@ ScopedJavaLocalRef<jobject> WalkAXTreeDepthFirst(JNIEnv* env,
   ScopedJavaLocalRef<jstring> j_class =
       ConvertUTF8ToJavaString(env, node->GetClassName());
   const gfx::Rect& location = node->GetLocation();
+  // The style attributes exists and valid if size attribute exists. Otherwise,
+  // they are not. Use a negative size information to indicate the existence
+  // of style information.
+  float size = -1.0;
+  int color = 0;
+  int bgcolor = 0;
+  int text_style = 0;
+  if (node->HasFloatAttribute(ui::AX_ATTR_FONT_SIZE)) {
+    color = node->GetIntAttribute(ui::AX_ATTR_COLOR);

[Ted C, 2015/05/29 17:04:29]

can you add a DCHECK above each one of these using Has<XXX>Attribute?

[dmazzoni, 2015/05/29 17:06:01]

No, we deliberately filter out zero values and empty strings from attributes so
if you want the value of the attribute including possibly zero, this is the
right way to do it.

[Ted C, 2015/05/29 17:10:37]

Huh?

So HasFloatAttribute returns false if the value is 0?  I'm more concerned that
all these attributes are associated with size, which seems odd/bad/incorrect to
me.

I'd rather have some means of asserting that is true and that if size is
specified
then so is everything else.  So if there is no way to do it currently, it seems
like something we should add and a TODO should be here referencing the bug for
it.

[sgurun-gerrit only, 2015/05/29 17:23:19]

I will add a todo and a crbug and we can discuss how to do it better there.
maybe a better way to encapsulate this information is having something like
hasStyleInformation hiding all the internal details.

+    bgcolor = node->GetIntAttribute(ui::AX_ATTR_BACKGROUND_COLOR);
+    size =  node->GetFloatAttribute(ui::AX_ATTR_FONT_SIZE);
+    text_style = node->GetIntAttribute(ui::AX_ATTR_TEXT_STYLE);
+  }
+
   ScopedJavaLocalRef<jobject> j_node =
       Java_WebContentsImpl_createAccessibilitySnapshotNode(env,
           location.x(), location.y(), node->GetScrollX(),
           node->GetScrollY(), location.width(), location.height(),
-          j_text.obj(), j_class.obj());
+          j_text.obj(), color, bgcolor, size, text_style, j_class.obj());
 
   for(uint32 i = 0; i < node->PlatformChildCount(); i++) {
     BrowserAccessibilityAndroid* child =