content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java - Issue 1137393003: Add style information to the snapshot node

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

Issue 1137393003: Add style information to the snapshot node (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gn support Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/web_contents/web_contents_android.cc ('K') | « content/public/android/BUILD.gn ('k') | content/public/android/java/src/org/chromium/content_public/browser/AccessibilitySnapshotNode.java » ('j') | ui/accessibility/ax_enums.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

index be0c55d4a09d0890ca779f9b926b760cd42c5eb6..5e18aa86a754608bb26541e15fca0b56bedfc295 100644

--- a/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

+++ b/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java

@@ -15,6 +15,7 @@ import org.chromium.content_public.browser.NavigationController;

import org.chromium.content_public.browser.NavigationTransitionDelegate;

import org.chromium.content_public.browser.WebContents;

import org.chromium.content_public.browser.WebContentsObserver;

+import org.chromium.ui.accessibility.AXTextStyle;

/**

* The WebContentsImpl Java wrapper to allow communicating with the native WebContentsImpl

@@ -356,9 +357,14 @@ import org.chromium.content_public.browser.WebContentsObserver;

@CalledByNative

private static AccessibilitySnapshotNode createAccessibilitySnapshotNode(int x,

int y, int scrollX, int scrollY, int width, int height, String text,

- String className) {

+ int color, int bgcolor, float size, int textStyle, String className) {

+ boolean bold = (textStyle & AXTextStyle.text_style_bold) > 0;

+ boolean italic = (textStyle & AXTextStyle.text_style_italic) > 0;

+ boolean underline = (textStyle & AXTextStyle.text_style_underline) > 0;

+ boolean lineThrough = (textStyle & AXTextStyle.text_style_line_through) > 0;

return new AccessibilitySnapshotNode(x, y, scrollX, scrollY, width, height, text,

- className);

+ color, bgcolor, size, bold, italic, underline, lineThrough, className);

}

@Override