Add style information to the snapshot node

content/browser/web_contents/web_contents_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_array.h"
 #include "base/android/jni_string.h"
 #include "base/command_line.h"
@@ skipping 42 matching lines @@
 }
 
 ScopedJavaLocalRef<jobject> WalkAXTreeDepthFirst(JNIEnv* env,
       BrowserAccessibilityAndroid* node) {
 
   ScopedJavaLocalRef<jstring> j_text =
       ConvertUTF16ToJavaString(env, node->GetText());
   ScopedJavaLocalRef<jstring> j_class =
       ConvertUTF8ToJavaString(env, node->GetClassName());
   const gfx::Rect& location = node->GetLocation();
+  int color = node->GetIntAttribute(ui::AX_ATTR_COLOR);

[Ted C, 2015/05/27 18:45:39]

GetIntAttribute returns 0 when this isn't defined.  For color, that will default
to transparent on android, which probably isn't what you want.

Should this use the function that returns a boolean and only use the color if
defined otherwise default to 0xFF000000 ?

Same for bgcolor and size, should we default to some decent constant if
undefined?

[sgurun-gerrit only, 2015/05/27 19:27:24]

good point, I actually missed it. It is more attractive to pass a decent
constant (for not making JNI interface even more crowded) but then I don't know
what a decent constant would be.

[sgurun-gerrit only, 2015/05/27 19:42:26]

ok, talked to Dominic about it. We will check if size exists or not. if size
exists, we will read all the attributes and pass to Java, otherwise, we will not
pass anything.

[sgurun-gerrit only, 2015/05/29 00:35:24]

Done.

+  int bgcolor = node->GetIntAttribute(ui::AX_ATTR_BACKGROUND_COLOR);
+  float size =  node->GetFloatAttribute(ui::AX_ATTR_FONT_SIZE);
+  int text_style = node->GetIntAttribute(ui::AX_ATTR_TEXT_STYLE);
+
   ScopedJavaLocalRef<jobject> j_node =
       Java_WebContentsImpl_createAccessibilitySnapshotNode(env,
           location.x(), location.y(), node->GetScrollX(),
           node->GetScrollY(), location.width(), location.height(),
-          j_text.obj(), j_class.obj());
+          j_text.obj(), color, bgcolor, size, text_style, j_class.obj());
 
   for(uint32 i = 0; i < node->PlatformChildCount(); i++) {
     BrowserAccessibilityAndroid* child =
         static_cast<BrowserAccessibilityAndroid*>(
             node->PlatformGetChild(i));
     Java_WebContentsImpl_addAccessibilityNodeAsChild(env,
         j_node.obj(), WalkAXTreeDepthFirst(env, child).obj());
   }
   return j_node;
 }
@@ skipping 488 matching lines @@
   ScopedJavaGlobalRef<jobject> j_callback;
   j_callback.Reset(env, callback);
   WebContentsImpl::AXTreeSnapshotCallback snapshot_callback =
       base::Bind(&AXTreeSnapshotCallback, j_callback);
 
   static_cast<WebContentsImpl*>(web_contents_)->RequestAXTreeSnapshot(
       snapshot_callback);
 }
 
 }  // namespace content