Issue 1137373004: [Effen] Make the stock app use the radio button widget so that it's being tested.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1137373004: [Effen] Make the stock app use the radio button widget so that it's being tested. (Closed)

Created:
5 years, 7 months ago by Hixie

Modified:
5 years, 7 months ago

Reviewers:
eseidel

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

[Effen] Make the stock app use the radio button widget so that it's being tested. Changes: - adds a couple of radio buttons to the drawer menu list. - makes menu items support being tapped and reporting the tap. - hooks up the checkbox to actually support being checked. - changes the drawer menu items to make more sense in a stock app. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e6d060c3f686fc51c89f5d4efba903245e554287

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -25 lines)			Patch
M	sky/examples/stocks/lib/stock_app.dart	View	5 chunks	+48 lines, -8 lines	0 comments	Download
M	sky/framework/components/menu_item.dart	View	2 chunks	+22 lines, -16 lines	0 comments	Download
M	sky/framework/fn.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Hixie

5 years, 7 months ago (2015-05-14 20:16:39 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e6d060c3f686fc51c89f5d4efba903245e554287 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages