Enable blink_gc_plugin tests on Windows.

Enable blink_gc_plugin tests on Windows.

BUG=486571
R=thakis@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/31a6cb0ee484ebf9f40a84e617a6b8649d1f710b

[dcheng, 2015-05-14 05:26:38]

dcheng@chromium.org changed reviewers:
+ thakis@chromium.org

[dcheng, 2015-05-14 05:28:19]

I also fixed a few random bugs that slipped into the testing script.

Note that not all plugin tests pass atm on Windows, but I think this will be
useful to diagnose and track down the issues.

https://codereview.chromium.org/1137373002/diff/20001/tools/clang/blink_gc_pl...
File tools/clang/blink_gc_plugin/tests/test.py (right):

https://codereview.chromium.org/1137373002/diff/20001/tools/clang/blink_gc_pl...
tools/clang/blink_gc_plugin/tests/test.py:48: os.remove('%s.graph.json' %
test_base_name)
This caused me to miss that -fsyntax-only isn't actually good enough.

https://codereview.chromium.org/1137373002/diff/20001/tools/clang/blink_gc_pl...
tools/clang/blink_gc_plugin/tests/test.py:60: open('%s.txt.actual' %
test_base_name, 'w').write(actual)
Somehow I checked in the wrong version of this file

[Nico, 2015-05-14 05:34:19]

lgtm if it works.

Sounds like the tests are finding our [blink-gc] bug! :-)

https://codereview.chromium.org/1137373002/diff/20001/tools/clang/blink_gc_pl...
File tools/clang/blink_gc_plugin/CMakeLists.txt (right):

https://codereview.chromium.org/1137373002/diff/20001/tools/clang/blink_gc_pl...
tools/clang/blink_gc_plugin/CMakeLists.txt:24: cr_add_test(blink_gc_plugin_test
nit: If this doesn't pass yet, I'd probably add this in commented out with a "#
TODO: Enable once it passes".

(Dunno if the bots will even go red without that?)

[dcheng, 2015-05-14 05:39:55]

https://codereview.chromium.org/1137373002/diff/20001/tools/clang/blink_gc_pl...
File tools/clang/blink_gc_plugin/CMakeLists.txt (right):

https://codereview.chromium.org/1137373002/diff/20001/tools/clang/blink_gc_pl...
tools/clang/blink_gc_plugin/CMakeLists.txt:24: cr_add_test(blink_gc_plugin_test
On 2015/05/14 05:34:19, Nico wrote:
> nit: If this doesn't pass yet, I'd probably add this in commented out with a
"#
> TODO: Enable once it passes".
> 
> (Dunno if the bots will even go red without that?)

Since this is gated behind --run-tests (which the bots don't pass yet), I think
it's OK to leave this in.

WDYT?

[Nico, 2015-05-14 05:44:51]

Whatever you prefer :-)

On Wed, May 13, 2015 at 10:39 PM, <dcheng@chromium.org> wrote:

>
>
>
https://codereview.chromium.org/1137373002/diff/20001/tools/clang/blink_gc_pl...
> File tools/clang/blink_gc_plugin/CMakeLists.txt (right):
>
>
>
https://codereview.chromium.org/1137373002/diff/20001/tools/clang/blink_gc_pl...
> tools/clang/blink_gc_plugin/CMakeLists.txt:24:
> cr_add_test(blink_gc_plugin_test
> On 2015/05/14 05:34:19, Nico wrote:
>
>> nit: If this doesn't pass yet, I'd probably add this in commented out
>>
> with a "#
>
>> TODO: Enable once it passes".
>>
>
>  (Dunno if the bots will even go red without that?)
>>
>
> Since this is gated behind --run-tests (which the bots don't pass yet),
> I think it's OK to leave this in.
>
> WDYT?
>
> https://codereview.chromium.org/1137373002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-05-14 06:47:51]

Patchset 2 (id:??) landed as
https://crrev.com/31a6cb0ee484ebf9f40a84e617a6b8649d1f710b
Cr-Commit-Position: refs/heads/master@{#329814}

[dcheng, 2015-05-14 06:48:02]

Committed patchset #2 (id:20001) manually as
31a6cb0ee484ebf9f40a84e617a6b8649d1f710b (presubmit successful).