Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 1137363002: Replace action_runner.NavigateToPage with action_runner.Navigate(sel.url) (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace action_runner.NavigateToPage with action_runner.Navigate(sel.url) BUG=487800 Committed: https://crrev.com/9f78c24e5d31c3e9b2a3be6b93a69d359bb58785 Cr-Commit-Position: refs/heads/master@{#329757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/perf/page_sets/inbox.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
nednguyen
5 years, 7 months ago (2015-05-13 21:51:12 UTC) #2
sullivan
lgtm
5 years, 7 months ago (2015-05-13 21:54:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137363002/1
5 years, 7 months ago (2015-05-13 22:05:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 00:13:05 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 00:14:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f78c24e5d31c3e9b2a3be6b93a69d359bb58785
Cr-Commit-Position: refs/heads/master@{#329757}

Powered by Google App Engine
This is Rietveld 408576698