Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1137323005: Don't return wall clock times when time isn't ticking. (Closed)

Created:
5 years, 7 months ago by DaleCurtis
Modified:
5 years, 7 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't return wall clock times when time isn't ticking. The video renderer may request wall clock times before the audio renderer has notified the renderer that it has underflowed. We should refuse to convert wall clock times as soon as an underflow state is detected, instead of waiting for the renderer to pause everything on the media thread (which may be backed up for decoding or other events). BUG=489503 TEST=modified underflow test. Committed: https://crrev.com/c49e7c5523df7164ddada93fb8d826e96d0752f3 Cr-Commit-Position: refs/heads/master@{#330481}

Patch Set 1 #

Patch Set 2 : Include sink_playing_. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M media/renderers/audio_renderer_impl.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
DaleCurtis
5 years, 7 months ago (2015-05-19 00:36:20 UTC) #2
xhwang
lgtm
5 years, 7 months ago (2015-05-19 03:03:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137323005/20001
5 years, 7 months ago (2015-05-19 04:21:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 05:33:37 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 05:34:40 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c49e7c5523df7164ddada93fb8d826e96d0752f3
Cr-Commit-Position: refs/heads/master@{#330481}

Powered by Google App Engine
This is Rietveld 408576698