Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 1137323002: Add skia dependency for touch_selection when use_aura=1 (Closed)

Created:
5 years, 7 months ago by davve
Modified:
5 years, 7 months ago
Reviewers:
jdduke (slow)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add skia dependency for touch_selection when use_aura=1 Fixes linking errors with shared library component build.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Do the corresponding for GN and exclude non-aura #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ui/touch_selection/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M ui/touch_selection/ui_touch_selection.gyp View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jdduke (slow)
https://codereview.chromium.org/1137323002/diff/1/ui/touch_selection/ui_touch_selection.gyp File ui/touch_selection/ui_touch_selection.gyp (right): https://codereview.chromium.org/1137323002/diff/1/ui/touch_selection/ui_touch_selection.gyp#newcode15 ui/touch_selection/ui_touch_selection.gyp:15: '../../skia/skia.gyp:skia', Can you exclude skia for non-aura builds? (as ...
5 years, 7 months ago (2015-05-13 16:03:59 UTC) #2
davve
Thanks for the review! My first stab at updating a BUILD.gn file. gn gen out/Default ...
5 years, 7 months ago (2015-05-14 07:12:47 UTC) #3
jdduke (slow)
On 2015/05/14 07:12:47, David Vest wrote: > Thanks for the review! My first stab at ...
5 years, 7 months ago (2015-05-14 13:10:45 UTC) #4
jdduke (slow)
5 years, 7 months ago (2015-05-14 13:10:48 UTC) #5
On 2015/05/14 07:12:47, David Vest wrote:
> Thanks for the review! My first stab at updating a BUILD.gn file. gn gen
> out/Default seemed content with the change, but I haven't verified further
than
> that. Hopefully a try bot will do that.

I think somebody from Intel beat you to it, should be fixed now. Bit yeah, shame
the CQ doesn't catch this.

Powered by Google App Engine
This is Rietveld 408576698