Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: build/config/android/rules.gni

Issue 1137313003: Add use_apk_split parameter to java_apk.gypi / android_apk (gn) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@package_resources
Patch Set: Disable load_library_from_zip for incomplete apk Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/android/rules.gni
diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni
index 168ebb4dea495060bccde50901842073db660bb6..31b95fff03dd47309dbdea5c0bde3ef4eebfe443 100644
--- a/build/config/android/rules.gni
+++ b/build/config/android/rules.gni
@@ -1204,7 +1204,7 @@ template("android_apk") {
base_path = "$gen_dir/$target_name"
_build_config = "$target_gen_dir/$target_name.build_config"
resources_zip_path = "$base_path.resources.zip"
- all_resources_zip_path = "$base_path.resources.all.zip"
+ _all_resources_zip_path = "$base_path.resources.all.zip"
jar_path = "$base_path.jar"
final_dex_path = "$gen_dir/classes.dex"
_template_name = target_name
@@ -1222,6 +1222,15 @@ template("android_apk") {
_native_libs = []
+ _version_code = "1"
+ if (defined(invoker.version_code)) {
+ _version_code = invoker.version_code
+ }
+
+ _version_name = "Developer Build"
+ if (defined(invoker.version_name)) {
+ _version_name = invoker.version_name
+ }
_keystore_path = android_default_keystore_path
_keystore_name = android_default_keystore_name
_keystore_password = android_default_keystore_password
@@ -1287,6 +1296,12 @@ template("android_apk") {
_android_manifest = invoker.android_manifest
_rebased_build_config = rebase_path(_build_config, root_build_dir)
+ use_abi_split = defined(invoker.use_abi_split) && invoker.use_abi_split
+
+ # Assert to avoid error:
+ # You set the variable "use_abi_split" here and it was unused before it
+ # went out of scope.
+ assert(use_abi_split || !use_abi_split)
write_build_config("${_template_name}__build_config") {
type = "android_apk"
@@ -1315,6 +1330,7 @@ template("android_apk") {
android_manifest = _android_manifest
resource_dirs = [ "//build/android/ant/empty/res" ]
zip_path = resources_zip_path
+ all_resources_zip_path = _all_resources_zip_path
generate_constant_ids = true
build_config = _build_config
@@ -1471,19 +1487,12 @@ template("android_apk") {
create_apk("${_template_name}__create") {
apk_path = _final_apk_path
android_manifest = _android_manifest
- resources_zip = all_resources_zip_path
+ resources_zip = _all_resources_zip_path
dex_path = final_dex_path
load_library_from_apk = _load_library_from_apk
- version_code = "1"
- if (defined(invoker.version_code)) {
- version_code = invoker.version_code
- }
-
- version_name = "Developer Build"
- if (defined(invoker.version_name)) {
- version_name = invoker.version_name
- }
+ version_code = _version_code
+ version_name = _version_name
keystore_name = _keystore_name
keystore_path = _keystore_path
@@ -1501,12 +1510,48 @@ template("android_apk") {
}
}
- if (_native_libs != []) {
+ if (_native_libs != [] && !use_abi_split) {
native_libs_dir = _native_libs_dir
deps += [ ":${_template_name}__prepare_native" ]
}
}
+ if (_native_libs != [] && use_abi_split) {
+ manifest_rule = "${_template_name}__split_manifest_abi_${target_cpu}"
+ generate_split_manifest(manifest_rule) {
+ main_manifest = _android_manifest
+ out_manifest =
+ "$gen_dir/split-manifests/${target_cpu}/AndroidManifest.xml"
+ split_name = "abi_${target_cpu}"
+ }
+
+ apk_rule = "${_template_name}__split_apk_abi_${target_cpu}"
+ final_deps += [ ":$apk_rule" ]
+ create_apk(apk_rule) {
+ split_paths = process_file_template(
+ [ _final_apk_path ],
+ "{{source_dir}}/{{source_name_part}}_abi_${target_cpu}.apk")
+ apk_path = split_paths[0]
+ base_path = "$gen_dir/$apk_rule"
+
+ manifest_outputs = get_target_outputs(":${manifest_rule}")
+ android_manifest = manifest_outputs[1]
+ load_library_from_apk = _load_library_from_apk
+
+ version_code = _version_code
+ version_name = _version_name
+
+ keystore_name = _keystore_name
+ keystore_path = _keystore_path
+ keystore_password = _keystore_password
+
+ native_libs_dir = _native_libs_dir
+ deps = [
+ ":${_template_name}__prepare_native",
+ ]
+ }
+ }
+
group(target_name) {
deps = final_deps
if (defined(invoker.datadeps)) {
« no previous file with comments | « build/android/finalize_apk_action.gypi ('k') | build/java_apk.gypi » ('j') | build/java_apk.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698