build/android/finalize_apk_action.gypi - Issue 1137313003: Add use_apk_split parameter to java_apk.gypi / android_apk (gn)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/finalize_apk_action.gypi

Issue 1137313003: Add use_apk_split parameter to java_apk.gypi / android_apk (gn) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@package_resources

Patch Set: use_split_apk -> create_split_apk Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java ('K') | « base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java ('k') | build/config/android/rules.gni » ('j') | build/config/android/rules.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/finalize_apk_action.gypi

diff --git a/build/android/finalize_apk_action.gypi b/build/android/finalize_apk_action.gypi

index bdf996604bdb07f21d9a8a4de2016c5156459479..0818d9768e2428430777e4e396640d01a86541a9 100644

--- a/build/android/finalize_apk_action.gypi

+++ b/build/android/finalize_apk_action.gypi

@@ -24,6 +24,7 @@

'keystore_password%': 'chromium',

'zipalign_path%': '<(android_sdk_tools)/zipalign',

'rezip_apk_jar_path%': '<(PRODUCT_DIR)/lib.java/rezip_apk.jar',

+ 'load_library_from_zip%': 0,

'inputs': [

'<(DEPTH)/build/android/gyp/finalize_apk.py',

@@ -42,7 +43,7 @@

'--key-path=<(keystore_path)',

'--key-name=<(keystore_name)',

'--key-passwd=<(keystore_password)',

- '--load-library-from-zip-file=<(load_library_from_zip_file)',

+ '--load-library-from-zip-file=<(load_library_from_zip)',

'--rezip-apk-jar-path=<(rezip_apk_jar_path)',

}