Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Side by Side Diff: build/config/android/rules.gni

Issue 1137313003: Add use_apk_split parameter to java_apk.gypi / android_apk (gn) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@package_resources
Patch Set: Fixed Linker to look in split for .so Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//base/android/linker/config.gni") 5 import("//base/android/linker/config.gni")
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/internal_rules.gni") 7 import("//build/config/android/internal_rules.gni")
8 import("//tools/grit/grit_rule.gni") 8 import("//tools/grit/grit_rule.gni")
9 import("//tools/relocation_packer/config.gni") 9 import("//tools/relocation_packer/config.gni")
10 10
(...skipping 1186 matching lines...) Expand 10 before | Expand all | Expand 10 after
1197 if (defined(invoker.testonly)) { 1197 if (defined(invoker.testonly)) {
1198 testonly = invoker.testonly 1198 testonly = invoker.testonly
1199 } 1199 }
1200 1200
1201 assert(defined(invoker.final_apk_path) || defined(invoker.apk_name)) 1201 assert(defined(invoker.final_apk_path) || defined(invoker.apk_name))
1202 assert(defined(invoker.android_manifest)) 1202 assert(defined(invoker.android_manifest))
1203 gen_dir = "$target_gen_dir/$target_name" 1203 gen_dir = "$target_gen_dir/$target_name"
1204 base_path = "$gen_dir/$target_name" 1204 base_path = "$gen_dir/$target_name"
1205 _build_config = "$target_gen_dir/$target_name.build_config" 1205 _build_config = "$target_gen_dir/$target_name.build_config"
1206 resources_zip_path = "$base_path.resources.zip" 1206 resources_zip_path = "$base_path.resources.zip"
1207 all_resources_zip_path = "$base_path.resources.all.zip" 1207 _all_resources_zip_path = "$base_path.resources.all.zip"
1208 jar_path = "$base_path.jar" 1208 jar_path = "$base_path.jar"
1209 final_dex_path = "$gen_dir/classes.dex" 1209 final_dex_path = "$gen_dir/classes.dex"
1210 _template_name = target_name 1210 _template_name = target_name
1211 _final_apk_path = "" 1211 _final_apk_path = ""
1212 if (defined(invoker.final_apk_path)) { 1212 if (defined(invoker.final_apk_path)) {
1213 _final_apk_path = invoker.final_apk_path 1213 _final_apk_path = invoker.final_apk_path
1214 } else if (defined(invoker.apk_name)) { 1214 } else if (defined(invoker.apk_name)) {
1215 _final_apk_path = "$root_build_dir/apks/" + invoker.apk_name + ".apk" 1215 _final_apk_path = "$root_build_dir/apks/" + invoker.apk_name + ".apk"
1216 } 1216 }
1217 _dist_jar_path_list = 1217 _dist_jar_path_list =
1218 process_file_template( 1218 process_file_template(
1219 [ _final_apk_path ], 1219 [ _final_apk_path ],
1220 "$root_build_dir/test.lib.java/{{source_name_part}}.jar") 1220 "$root_build_dir/test.lib.java/{{source_name_part}}.jar")
1221 _dist_jar_path = _dist_jar_path_list[0] 1221 _dist_jar_path = _dist_jar_path_list[0]
1222 1222
1223 _native_libs = [] 1223 _native_libs = []
1224 1224
1225 _version_code = "1"
1226 if (defined(invoker.version_code)) {
1227 _version_code = invoker.version_code
1228 }
1229
1230 _version_name = "Developer Build"
1231 if (defined(invoker.version_name)) {
1232 _version_name = invoker.version_name
1233 }
1225 _keystore_path = android_default_keystore_path 1234 _keystore_path = android_default_keystore_path
1226 _keystore_name = android_default_keystore_name 1235 _keystore_name = android_default_keystore_name
1227 _keystore_password = android_default_keystore_password 1236 _keystore_password = android_default_keystore_password
1228 1237
1229 if (defined(invoker.keystore_path)) { 1238 if (defined(invoker.keystore_path)) {
1230 _keystore_path = invoker.keystore_path 1239 _keystore_path = invoker.keystore_path
1231 _keystore_name = invoker.keystore_name 1240 _keystore_name = invoker.keystore_name
1232 _keystore_password = invoker.keystore_password 1241 _keystore_password = invoker.keystore_password
1233 } 1242 }
1234 1243
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
1280 } 1289 }
1281 1290
1282 _native_lib_version_name = "" 1291 _native_lib_version_name = ""
1283 if (defined(invoker.native_lib_version_name)) { 1292 if (defined(invoker.native_lib_version_name)) {
1284 _native_lib_version_name = invoker.native_lib_version_name 1293 _native_lib_version_name = invoker.native_lib_version_name
1285 } 1294 }
1286 } 1295 }
1287 1296
1288 _android_manifest = invoker.android_manifest 1297 _android_manifest = invoker.android_manifest
1289 _rebased_build_config = rebase_path(_build_config, root_build_dir) 1298 _rebased_build_config = rebase_path(_build_config, root_build_dir)
1299 use_abi_split = defined(invoker.use_abi_split) && invoker.use_abi_split
1300
1301 # Assert to avoid error:
1302 # You set the variable "use_abi_split" here and it was unused before it
1303 # went out of scope.
1304 assert(use_abi_split || !use_abi_split)
1290 1305
1291 write_build_config("${_template_name}__build_config") { 1306 write_build_config("${_template_name}__build_config") {
1292 type = "android_apk" 1307 type = "android_apk"
1293 dex_path = final_dex_path 1308 dex_path = final_dex_path
1294 resources_zip = resources_zip_path 1309 resources_zip = resources_zip_path
1295 build_config = _build_config 1310 build_config = _build_config
1296 android_manifest = _android_manifest 1311 android_manifest = _android_manifest
1297 1312
1298 if (defined(invoker.deps)) { 1313 if (defined(invoker.deps)) {
1299 deps = invoker.deps 1314 deps = invoker.deps
1300 } 1315 }
1301 1316
1302 if (defined(invoker.apk_under_test)) { 1317 if (defined(invoker.apk_under_test)) {
1303 apk_under_test = invoker.apk_under_test 1318 apk_under_test = invoker.apk_under_test
1304 } 1319 }
1305 1320
1306 native_libs = _native_libs 1321 native_libs = _native_libs
1307 } 1322 }
1308 1323
1309 final_deps = [] 1324 final_deps = []
1310 1325
1311 final_deps += [ ":${_template_name}__process_resources" ] 1326 final_deps += [ ":${_template_name}__process_resources" ]
1312 process_resources("${_template_name}__process_resources") { 1327 process_resources("${_template_name}__process_resources") {
1313 srcjar_path = "${target_gen_dir}/${target_name}.srcjar" 1328 srcjar_path = "${target_gen_dir}/${target_name}.srcjar"
1314 r_text_path = "${target_gen_dir}/${target_name}_R.txt" 1329 r_text_path = "${target_gen_dir}/${target_name}_R.txt"
1315 android_manifest = _android_manifest 1330 android_manifest = _android_manifest
1316 resource_dirs = [ "//build/android/ant/empty/res" ] 1331 resource_dirs = [ "//build/android/ant/empty/res" ]
1317 zip_path = resources_zip_path 1332 zip_path = resources_zip_path
1333 all_resources_zip_path = _all_resources_zip_path
1318 generate_constant_ids = true 1334 generate_constant_ids = true
1319 build_config = _build_config 1335 build_config = _build_config
1320 1336
1321 if (defined(invoker.include_all_resources)) { 1337 if (defined(invoker.include_all_resources)) {
1322 include_all_resources = invoker.include_all_resources 1338 include_all_resources = invoker.include_all_resources
1323 } 1339 }
1324 } 1340 }
1325 _srcjar_deps += [ ":${_template_name}__process_resources" ] 1341 _srcjar_deps += [ ":${_template_name}__process_resources" ]
1326 1342
1327 if (_native_libs != []) { 1343 if (_native_libs != []) {
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
1464 inputs += [ android_gdbserver ] 1480 inputs += [ android_gdbserver ]
1465 args += [ "--libraries=$rebased_gdbserver" ] 1481 args += [ "--libraries=$rebased_gdbserver" ]
1466 } 1482 }
1467 } 1483 }
1468 } 1484 }
1469 1485
1470 final_deps += [ ":${_template_name}__create" ] 1486 final_deps += [ ":${_template_name}__create" ]
1471 create_apk("${_template_name}__create") { 1487 create_apk("${_template_name}__create") {
1472 apk_path = _final_apk_path 1488 apk_path = _final_apk_path
1473 android_manifest = _android_manifest 1489 android_manifest = _android_manifest
1474 resources_zip = all_resources_zip_path 1490 resources_zip = _all_resources_zip_path
1475 dex_path = final_dex_path 1491 dex_path = final_dex_path
1476 load_library_from_apk = _load_library_from_apk 1492 load_library_from_apk = _load_library_from_apk
1477 1493
1478 version_code = "1" 1494 version_code = _version_code
1479 if (defined(invoker.version_code)) { 1495 version_name = _version_name
1480 version_code = invoker.version_code
1481 }
1482
1483 version_name = "Developer Build"
1484 if (defined(invoker.version_name)) {
1485 version_name = invoker.version_name
1486 }
1487 1496
1488 keystore_name = _keystore_name 1497 keystore_name = _keystore_name
1489 keystore_path = _keystore_path 1498 keystore_path = _keystore_path
1490 keystore_password = _keystore_password 1499 keystore_password = _keystore_password
1491 1500
1492 deps = [] 1501 deps = []
1493 if (defined(invoker.asset_location)) { 1502 if (defined(invoker.asset_location)) {
1494 asset_location = invoker.asset_location 1503 asset_location = invoker.asset_location
1495 1504
1496 # We don't know the exact dependencies that create the assets in 1505 # We don't know the exact dependencies that create the assets in
1497 # |asset_location|; we depend on all caller deps until a better solution 1506 # |asset_location|; we depend on all caller deps until a better solution
1498 # is figured out (http://crbug.com/433330). 1507 # is figured out (http://crbug.com/433330).
1499 if (defined(invoker.deps)) { 1508 if (defined(invoker.deps)) {
1500 deps += invoker.deps 1509 deps += invoker.deps
1501 } 1510 }
1502 } 1511 }
1503 1512
1504 if (_native_libs != []) { 1513 if (_native_libs != [] && !use_abi_split) {
1505 native_libs_dir = _native_libs_dir 1514 native_libs_dir = _native_libs_dir
1506 deps += [ ":${_template_name}__prepare_native" ] 1515 deps += [ ":${_template_name}__prepare_native" ]
1507 } 1516 }
1508 } 1517 }
1509 1518
1519 if (_native_libs != [] && use_abi_split) {
1520 manifest_rule = "${_template_name}__split_manifest_abi_${target_cpu}"
1521 generate_split_manifest(manifest_rule) {
1522 main_manifest = _android_manifest
1523 out_manifest =
1524 "$gen_dir/split-manifests/${target_cpu}/AndroidManifest.xml"
1525 split_name = "abi_${target_cpu}"
1526 }
1527
1528 apk_rule = "${_template_name}__split_apk_abi_${target_cpu}"
1529 final_deps += [ ":$apk_rule" ]
1530 create_apk(apk_rule) {
1531 split_paths = process_file_template(
1532 [ _final_apk_path ],
1533 "{{source_dir}}/{{source_name_part}}_abi_${target_cpu}.apk")
1534 apk_path = split_paths[0]
1535 base_path = "$gen_dir/$apk_rule"
1536
1537 manifest_outputs = get_target_outputs(":${manifest_rule}")
1538 android_manifest = manifest_outputs[1]
1539 load_library_from_apk = _load_library_from_apk
1540
1541 version_code = _version_code
1542 version_name = _version_name
1543
1544 keystore_name = _keystore_name
1545 keystore_path = _keystore_path
1546 keystore_password = _keystore_password
1547
1548 native_libs_dir = _native_libs_dir
1549 deps = [
1550 ":${_template_name}__prepare_native",
1551 ]
1552 }
1553 }
1554
1510 group(target_name) { 1555 group(target_name) {
1511 deps = final_deps 1556 deps = final_deps
1512 if (defined(invoker.datadeps)) { 1557 if (defined(invoker.datadeps)) {
1513 datadeps = invoker.datadeps 1558 datadeps = invoker.datadeps
1514 } 1559 }
1515 } 1560 }
1516 } 1561 }
1517 1562
1518 # Declare an Android gtest apk 1563 # Declare an Android gtest apk
1519 # 1564 #
(...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after
1813 template("uiautomator_test") { 1858 template("uiautomator_test") {
1814 set_sources_assignment_filter([]) 1859 set_sources_assignment_filter([])
1815 if (defined(invoker.testonly)) { 1860 if (defined(invoker.testonly)) {
1816 testonly = invoker.testonly 1861 testonly = invoker.testonly
1817 } 1862 }
1818 assert(target_name != "") 1863 assert(target_name != "")
1819 assert(invoker.deps != [] || true) 1864 assert(invoker.deps != [] || true)
1820 group(target_name) { 1865 group(target_name) {
1821 } 1866 }
1822 } 1867 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698