runtime/vm/intermediate_language_x64.cc - Issue 1137313002: VM: Set breakpoints on x64 and arm64 without patching code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_x64.cc

Issue 1137313002: VM: Set breakpoints on x64 and arm64 without patching code. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: re-upload from git workspace Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_x64.cc

diff --git a/runtime/vm/intermediate_language_x64.cc b/runtime/vm/intermediate_language_x64.cc

index fa08bfb1dbae2cabf48d1628aca45945ae0dbd8d..689f7e2e1a7948c2ee5b9fa050d6480984c8c66f 100644

--- a/runtime/vm/intermediate_language_x64.cc

+++ b/runtime/vm/intermediate_language_x64.cc

@@ -6420,7 +6420,9 @@ void DebugStepCheckInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

ASSERT(!compiler->is_optimizing());

StubCode* stub_code = compiler->isolate()->stub_code();

const ExternalLabel label(stub_code->DebugStepCheckEntryPoint());

- compiler->GenerateCall(token_pos(), &label, stub_kind_, locs());

+ __ CallPatchable(&label);

+ compiler->AddCurrentDescriptor(stub_kind_, Isolate::kNoDeoptId, token_pos());

+ compiler->RecordSafepoint(locs());

}

« no previous file with comments | « runtime/vm/debugger_x64.cc ('k') | no next file » | no next file with comments »