VM: Set breakpoints on x64 and arm64 without patching code.

runtime/vm/assembler_arm64.cc

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // NOLINT
 #if defined(TARGET_ARCH_ARM64)
 
 #include "vm/assembler.h"
 #include "vm/cpu.h"
 #include "vm/longjump.h"
@@ skipping 41 matching lines @@
     } else {
       object_pool_.AddObject(vacant, kNotPatchable);
     }
 
     if (stub_code->CallToRuntime_entry() != NULL) {
       object_pool_.AddExternalLabel(
           &stub_code->CallToRuntimeLabel(), kNotPatchable);
     } else {
       object_pool_.AddObject(vacant, kNotPatchable);
     }
-
-    // Create fixed object pool entries for debugger stubs.
-    if (stub_code->ICCallBreakpoint_entry() != NULL) {
-      intptr_t index =
-          object_pool_.AddExternalLabel(&stub_code->ICCallBreakpointLabel(),
-                                        kNotPatchable);
-      ASSERT(index == kICCallBreakpointCPIndex);
-    } else {
-      object_pool_.AddObject(vacant, kNotPatchable);
-    }
-    if (stub_code->ClosureCallBreakpoint_entry() != NULL) {
-      intptr_t index = object_pool_.AddExternalLabel(
-          &stub_code->ClosureCallBreakpointLabel(), kNotPatchable);
-      ASSERT(index == kClosureCallBreakpointCPIndex);
-    } else {
-      object_pool_.AddObject(vacant, kNotPatchable);
-    }
-    if (stub_code->RuntimeCallBreakpoint_entry() != NULL) {
-      intptr_t index = object_pool_.AddExternalLabel(
-          &stub_code->RuntimeCallBreakpointLabel(), kNotPatchable);
-      ASSERT(index == kRuntimeCallBreakpointCPIndex);
-    } else {
-      object_pool_.AddObject(vacant, kNotPatchable);
-    }
   }
 }
 
 
 void Assembler::InitializeMemoryWithBreakpoints(uword data, intptr_t length) {
   ASSERT(Utils::IsAligned(data, 4));
   ASSERT(Utils::IsAligned(length, 4));
   const uword end = data + length;
   while (data < end) {
     *reinterpret_cast<int32_t*>(data) = Instr::kBreakPointInstruction;
@@ skipping 1390 matching lines @@
     add(base, array, Operand(index, LSL, shift));
   }
   const OperandSize size = Address::OperandSizeFor(cid);
   ASSERT(Address::CanHoldOffset(offset, Address::Offset, size));
   return Address(base, offset, Address::Offset, size);
 }
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM64