|
VM: Set breakpoints on x64 and arm64 without patching code.
Instead of changing the generated code, change the target of calls
by changing the corresponding entry in the constant pool. Patchable
call sites can't share constant pool entries for now.
x64 and arm64 already had support for patching call targets in the
constant pool, but the debugger used to change the code instead.
This eliminates the fixed debugger stub entries in every constant pool.
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+117 lines, -291 lines) |
Patch |
 |
M |
runtime/vm/assembler_arm64.h
|
View
|
1
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
runtime/vm/assembler_arm64.cc
|
View
|
1
|
1 chunk |
+0 lines, -24 lines |
0 comments
|
Download
|
 |
M |
runtime/vm/assembler_x64.h
|
View
|
1
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
runtime/vm/assembler_x64.cc
|
View
|
1
|
1 chunk |
+0 lines, -23 lines |
0 comments
|
Download
|
 |
M |
runtime/vm/code_patcher.h
|
View
|
1
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
runtime/vm/code_patcher_arm.cc
|
View
|
1
|
1 chunk |
+0 lines, -11 lines |
0 comments
|
Download
|
 |
M |
runtime/vm/code_patcher_arm64.cc
|
View
|
1
|
2 chunks |
+32 lines, -30 lines |
0 comments
|
Download
|
 |
M |
runtime/vm/code_patcher_ia32.cc
|
View
|
1
|
1 chunk |
+0 lines, -11 lines |
0 comments
|
Download
|
 |
M |
runtime/vm/code_patcher_mips.cc
|
View
|
1
|
1 chunk |
+0 lines, -11 lines |
0 comments
|
Download
|
 |
M |
runtime/vm/code_patcher_x64.cc
|
View
|
1
|
2 chunks |
+23 lines, -51 lines |
0 comments
|
Download
|
 |
M |
runtime/vm/debugger_arm64.cc
|
View
|
1
|
2 chunks |
+28 lines, -59 lines |
0 comments
|
Download
|
 |
M |
runtime/vm/debugger_x64.cc
|
View
|
1
|
2 chunks |
+28 lines, -60 lines |
0 comments
|
Download
|
 |
M |
runtime/vm/intermediate_language_x64.cc
|
View
|
1
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
Total messages: 5 (1 generated)
|