Always update cursor visibility

Always update cursor visibility

otherwise the visibility state gets out of sync

BUG=471670
TEST=CursorWindowControllerTest.VisibilityTest

Committed: https://crrev.com/72f479bb5089b47f6adcbde622598c6baebb7f47
Cr-Commit-Position: refs/heads/master@{#329881}

[oshima, 2015-05-14 15:21:22]

Patchset #1 (id:1) has been deleted

[oshima, 2015-05-14 15:21:34]

oshima@chromium.org changed reviewers:
+ abodenha@chromium.org

[oshima, 2015-05-14 15:21:41]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-14 15:22:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137303004/20001

[commit-bot: I haz the power, 2015-05-14 16:40:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 16:40:11]

Dry run: Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Albert Bodenhamer, 2015-05-14 16:42:02]

https://codereview.chromium.org/1137303004/diff/20001/ash/display/cursor_wind...
File ash/display/cursor_window_controller.cc (left):

https://codereview.chromium.org/1137303004/diff/20001/ash/display/cursor_wind...
ash/display/cursor_window_controller.cc:31: 
Why the whitespace change?

https://codereview.chromium.org/1137303004/diff/20001/ash/display/cursor_wind...
ash/display/cursor_window_controller.cc:184: if (!cursor_window_)
What is the removed code supposed to accomplish? Is this just removing an
incorrect optimization?

https://codereview.chromium.org/1137303004/diff/20001/ash/display/cursor_wind...
File ash/display/cursor_window_controller.cc (right):

https://codereview.chromium.org/1137303004/diff/20001/ash/display/cursor_wind...
ash/display/cursor_window_controller.cc:271: 
And here?

[oshima, 2015-05-14 16:57:47]

Patchset #2 (id:40001) has been deleted

[oshima, 2015-05-14 16:58:52]

new lines removed.

https://codereview.chromium.org/1137303004/diff/20001/ash/display/cursor_wind...
File ash/display/cursor_window_controller.cc (left):

https://codereview.chromium.org/1137303004/diff/20001/ash/display/cursor_wind...
ash/display/cursor_window_controller.cc:184: if (!cursor_window_)
On 2015/05/14 16:42:02, Albert Bodenhamer wrote:
> What is the removed code supposed to accomplish? Is this just removing an
> incorrect optimization?

The visibility state has to be updated regardless of cursor_window_ so that when
composition is enabled, it uses the correct visibility state. (see CL
description)

[oshima, 2015-05-14 16:59:11]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2015-05-14 16:59:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137303004/60001

[commit-bot: I haz the power, 2015-05-14 16:59:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-14 16:59:40]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Albert Bodenhamer, 2015-05-14 17:05:48]

lgtm

[oshima, 2015-05-14 17:22:17]

On 2015/05/14 16:59:40, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer,
> _not_ a full super star committer.
> See http://www.chromium.org/getting-involved/become-a-committer
> Note that this has nothing to do with OWNERS files.

oops, sorry. I meant to click dry run.

[oshima, 2015-05-14 17:22:19]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2015-05-14 17:22:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137303004/60001

[commit-bot: I haz the power, 2015-05-14 18:25:49]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2015-05-14 18:26:47]

Patchset 2 (id:??) landed as
https://crrev.com/72f479bb5089b47f6adcbde622598c6baebb7f47
Cr-Commit-Position: refs/heads/master@{#329881}