Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1137293002: Add regression test for resolving "this" in debug evaluate. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
Michael Hablich
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add regression test for resolving "this" in debug evaluate. R=hablich@chromium.org BUG=chromium:487289 LOG=N Committed: https://crrev.com/d8e9f3a484771b8c83ebdea5504814999247c365 Cr-Commit-Position: refs/heads/master@{#28424}

Patch Set 1 #

Patch Set 2 : fix flags #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -0 lines) Patch
A test/mjsunit/regress/regress-crbug-487289.js View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
Yang
5 years, 7 months ago (2015-05-13 12:52:54 UTC) #1
Michael Hablich
On 2015/05/13 12:52:54, Yang wrote: lgtm
5 years, 7 months ago (2015-05-13 12:58:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137293002/1
5 years, 7 months ago (2015-05-13 13:54:45 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/2659)
5 years, 7 months ago (2015-05-13 14:06:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137293002/1
5 years, 7 months ago (2015-05-13 14:10:13 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/2661)
5 years, 7 months ago (2015-05-13 14:20:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137293002/1
5 years, 7 months ago (2015-05-15 07:16:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/2694)
5 years, 7 months ago (2015-05-15 07:29:46 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137293002/20001
5 years, 7 months ago (2015-05-15 13:32:17 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 13:57:41 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 13:57:55 UTC) #19
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/d8e9f3a484771b8c83ebdea5504814999247c365
Cr-Commit-Position: refs/heads/master@{#28424}

Powered by Google App Engine
This is Rietveld 408576698