Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1137283002: Prettify URIs for blacklisted entries on the chrome://settings/passwords page. (Closed)

Created:
5 years, 7 months ago by engedy
Modified:
5 years, 7 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, gcasto+watchlist_chromium.org, michaelpg+watch-options_chromium.org, vabr+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prettify URIs for blacklisted entries on the chrome://settings/passwords page. Use the same logic as for normal Android app credentials to avoid displaying the lengthy hash part of android:// URIs. BUG=486736 Committed: https://crrev.com/6501a77549f77dc8f60ece7fce578085bc0e7c83 Cr-Commit-Position: refs/heads/master@{#329623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/webui/options/password_manager_handler.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
engedy
@Vaclav, could you please take a look? @Bernhard, could you please review for OWNER's approval?
5 years, 7 months ago (2015-05-13 11:09:37 UTC) #3
vabr (Chromium)
lgtm
5 years, 7 months ago (2015-05-13 11:15:17 UTC) #4
Bernhard Bauer
lgtm
5 years, 7 months ago (2015-05-13 11:32:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137283002/1
5 years, 7 months ago (2015-05-13 11:33:15 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 13:04:16 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 13:05:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6501a77549f77dc8f60ece7fce578085bc0e7c83
Cr-Commit-Position: refs/heads/master@{#329623}

Powered by Google App Engine
This is Rietveld 408576698