Chromecast: adds CmaRenderer test coverage.

Chromecast: adds CmaRenderer test coverage.

This includes:
* Creating CmaRenderer and its dependencies (most of the renderer-side),
  stubbing out at the IPC level.
* Moving FakeDemuxerStream to media/base/ to allow use outside of //media

R=servolk@chromium.org,xhwang@chromium.org

Committed: https://crrev.com/780d39fe5c9bce4e35ea88f916ae79a9febe7a01
Cr-Commit-Position: refs/heads/master@{#330001}

[gunsch, 2015-05-13 07:45:48]

Sergey/Xiaohan: PTAL!

[xhwang, 2015-05-14 05:06:37]

Moving FakeDemuxerStream to media/base/ lgtm. In the future we may want to put
these test classes under media/base/test

[servolk, 2015-05-14 20:53:45]

On 2015/05/14 05:06:37, xhwang wrote:
> Moving FakeDemuxerStream to media/base/ lgtm. In the future we may want to put
> these test classes under media/base/test

lgtm, but see comment re fake demuxer stream provider.

[servolk, 2015-05-14 20:54:15]

https://codereview.chromium.org/1137263002/diff/1/chromecast/renderer/media/c...
File chromecast/renderer/media/cma_renderer_unittest.cc (right):

https://codereview.chromium.org/1137263002/diff/1/chromecast/renderer/media/c...
chromecast/renderer/media/cma_renderer_unittest.cc:33: class
FakeDemuxerStreamProvider : public ::media::DemuxerStreamProvider {
Looks like this might be potentially useful for other renderer tests as well.
Would it make sense to add it to fake_demuxer_stream.h instead of under
chromecast directory ? I think people outside of chromecast would be more likely
to find it there.

[gunsch, 2015-05-14 22:01:15]

https://codereview.chromium.org/1137263002/diff/1/chromecast/renderer/media/c...
File chromecast/renderer/media/cma_renderer_unittest.cc (right):

https://codereview.chromium.org/1137263002/diff/1/chromecast/renderer/media/c...
chromecast/renderer/media/cma_renderer_unittest.cc:33: class
FakeDemuxerStreamProvider : public ::media::DemuxerStreamProvider {
On 2015/05/14 20:54:15, servolk wrote:
> Looks like this might be potentially useful for other renderer tests as well.
> Would it make sense to add it to fake_demuxer_stream.h instead of under
> chromecast directory ? I think people outside of chromecast would be more
likely
> to find it there.

Done. xhwang@, are you okay with this change?

[gunsch, 2015-05-14 22:01:22]

The CQ bit was checked by gunsch@chromium.org to run a CQ dry run

[gunsch, 2015-05-14 22:01:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
servolk@chromium.org, xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1137263002/#ps20001
(title: "moved FakeDemuxerStreamProvider to media/base/")

[commit-bot: I haz the power, 2015-05-14 22:02:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137263002/20001

[xhwang, 2015-05-14 22:10:10]

lgtm % nits.

https://codereview.chromium.org/1137263002/diff/20001/media/base/fake_demuxer...
File media/base/fake_demuxer_stream.cc (right):

https://codereview.chromium.org/1137263002/diff/20001/media/base/fake_demuxer...
media/base/fake_demuxer_stream.cc:209: // Note: FakeDemuxerStream only supports
video
Move this comment to the .h file.

https://codereview.chromium.org/1137263002/diff/20001/media/base/fake_demuxer...
File media/base/fake_demuxer_stream.h (right):

https://codereview.chromium.org/1137263002/diff/20001/media/base/fake_demuxer...
media/base/fake_demuxer_stream.h:113: DemuxerStream*
GetStream(DemuxerStream::Type type) override;
// DemuxerStreamProvider implementation.

https://codereview.chromium.org/1137263002/diff/20001/media/base/fake_demuxer...
media/base/fake_demuxer_stream.h:116: ::media::FakeDemuxerStream
fake_video_stream_;
Drop the ::media:: part :)

[gunsch, 2015-05-14 22:15:08]

gunsch@chromium.org changed reviewers:
+ thakis@chromium.org

[gunsch, 2015-05-14 22:15:09]

Thanks!

+thakis: can you take a look for testing/buildbot/ OWNERS? Adding a new test
target to the Cast Linux test list. (I was hopeful the cast_shell_linux trybot
might pick it up, but it appears not).

https://codereview.chromium.org/1137263002/diff/20001/media/base/fake_demuxer...
File media/base/fake_demuxer_stream.cc (right):

https://codereview.chromium.org/1137263002/diff/20001/media/base/fake_demuxer...
media/base/fake_demuxer_stream.cc:209: // Note: FakeDemuxerStream only supports
video
On 2015/05/14 22:10:10, xhwang wrote:
> Move this comment to the .h file.

Done.

https://codereview.chromium.org/1137263002/diff/20001/media/base/fake_demuxer...
File media/base/fake_demuxer_stream.h (right):

https://codereview.chromium.org/1137263002/diff/20001/media/base/fake_demuxer...
media/base/fake_demuxer_stream.h:113: DemuxerStream*
GetStream(DemuxerStream::Type type) override;
On 2015/05/14 22:10:10, xhwang wrote:
> // DemuxerStreamProvider implementation.

Done.

https://codereview.chromium.org/1137263002/diff/20001/media/base/fake_demuxer...
media/base/fake_demuxer_stream.h:116: ::media::FakeDemuxerStream
fake_video_stream_;
On 2015/05/14 22:10:10, xhwang wrote:
> Drop the ::media:: part :)

Done.

[gunsch, 2015-05-14 22:15:15]

The CQ bit was checked by gunsch@chromium.org to run a CQ dry run

[gunsch, 2015-05-14 22:15:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
servolk@chromium.org, xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1137263002/#ps40001
(title: "some nits")

[commit-bot: I haz the power, 2015-05-14 22:15:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137263002/40001

[Nico, 2015-05-14 22:57:51]

On 2015/05/14 22:15:09, gunsch wrote:
> Thanks!
> 
> +thakis: can you take a look for testing/buildbot/ OWNERS? Adding a new test
> target to the Cast Linux test list. (I was hopeful the cast_shell_linux trybot
> might pick it up, but it appears not).

chromium.fyi.json is only for bots on the fyi waterfall. This will add the test
to the "Cast Linux" bot on http://build.chromium.org/p/chromium.fyi/waterfall
which seems to not exist. Is that what you want? (There's also
testing/buildbot/chromium_tryserver.json and chromium.linux.json . `git log` in
that directory has a bunch of examples)

> 
>
https://codereview.chromium.org/1137263002/diff/20001/media/base/fake_demuxer...
> File media/base/fake_demuxer_stream.cc (right):
> 
>
https://codereview.chromium.org/1137263002/diff/20001/media/base/fake_demuxer...
> media/base/fake_demuxer_stream.cc:209: // Note: FakeDemuxerStream only
supports
> video
> On 2015/05/14 22:10:10, xhwang wrote:
> > Move this comment to the .h file.
> 
> Done.
> 
>
https://codereview.chromium.org/1137263002/diff/20001/media/base/fake_demuxer...
> File media/base/fake_demuxer_stream.h (right):
> 
>
https://codereview.chromium.org/1137263002/diff/20001/media/base/fake_demuxer...
> media/base/fake_demuxer_stream.h:113: DemuxerStream*
> GetStream(DemuxerStream::Type type) override;
> On 2015/05/14 22:10:10, xhwang wrote:
> > // DemuxerStreamProvider implementation.
> 
> Done.
> 
>
https://codereview.chromium.org/1137263002/diff/20001/media/base/fake_demuxer...
> media/base/fake_demuxer_stream.h:116: ::media::FakeDemuxerStream
> fake_video_stream_;
> On 2015/05/14 22:10:10, xhwang wrote:
> > Drop the ::media:: part :)
> 
> Done.

[gunsch, 2015-05-14 23:05:43]

Patchset #4 (id:60001) has been deleted

[gunsch, 2015-05-14 23:06:22]

@thakis: good point, thanks for catching. We do have a bot on the chromium.linux
waterfall: http://build.chromium.org/p/chromium.linux/waterfall

which doesn't seem to be running anything! That's probably highly connected to
this test list being in chromium.fyi.json and not chromium.linux.json. I'll send
that as a separate CL.

[gunsch, 2015-05-14 23:06:29]

The CQ bit was checked by gunsch@chromium.org

[gunsch, 2015-05-14 23:06:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
servolk@chromium.org, xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1137263002/#ps80001
(title: "revert chromium.fyi.json change")

[commit-bot: I haz the power, 2015-05-14 23:07:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137263002/80001

[commit-bot: I haz the power, 2015-05-15 00:59:22]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-05-15 01:00:13]

Patchset 4 (id:??) landed as
https://crrev.com/780d39fe5c9bce4e35ea88f916ae79a9febe7a01
Cr-Commit-Position: refs/heads/master@{#330001}