Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1137253003: cros: Fix session restore on connection change. (Closed)

Created:
5 years, 7 months ago by xiyuan
Modified:
5 years, 7 months ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, dzhioev+watch_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, zel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cros: Fix session restore on connection change. - ContinueSessionRestore() should ensure SESSION_RESTORE_PREPARING state. Otherwise, /MergeSession is not called after /ListAccount because it would not be considered as is_pre_merge; - Cover SESSION_RESTORE_PREPARING state in connection change event; BUG=487476 Committed: https://crrev.com/8f05571bc82372de9880fca638fc9ff00024238b Cr-Commit-Position: refs/heads/master@{#329606}

Patch Set 1 #

Patch Set 2 : move PREPARE state setting to ContinueSessionRestore and cover it on connection change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/browser/chromeos/login/session/user_session_manager.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_manager.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_login_manager.cc View 1 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
xiyuan
5 years, 7 months ago (2015-05-13 02:38:39 UTC) #3
Nikita (slow)
lgtm
5 years, 7 months ago (2015-05-13 08:27:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137253003/40001
5 years, 7 months ago (2015-05-13 08:27:31 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-05-13 08:30:42 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 08:31:40 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8f05571bc82372de9880fca638fc9ff00024238b
Cr-Commit-Position: refs/heads/master@{#329606}

Powered by Google App Engine
This is Rietveld 408576698