Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4164)

Unified Diff: chrome/test/unit/chrome_test_suite.h

Issue 113725: We don't need stats table in unit tests. (Closed)
Patch Set: Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/unit/chrome_test_suite.h
diff --git a/chrome/test/unit/chrome_test_suite.h b/chrome/test/unit/chrome_test_suite.h
index a8d98f37a6eb5dc1d5cdf9adfb0844debc3507d6..94556460413a1ab5b39f7397631fb9ec06ca9693 100644
--- a/chrome/test/unit/chrome_test_suite.h
+++ b/chrome/test/unit/chrome_test_suite.h
@@ -11,7 +11,6 @@
#include "app/app_paths.h"
#include "app/resource_bundle.h"
-#include "base/stats_table.h"
#include "base/file_util.h"
#if defined(OS_MACOSX)
#include "base/mac_util.h"
@@ -105,13 +104,6 @@ class ChromeTestSuite : public TestSuite {
// output, it'll pass regardless of the system language.
ResourceBundle::InitSharedInstance(L"en-us");
ResourceBundle::GetSharedInstance().LoadThemeResources();
-
- // initialize the global StatsTable for unit_tests
- std::string statsfile = "unit_tests";
- std::string pid_string = StringPrintf("-%d", base::GetCurrentProcId());
- statsfile += pid_string;
- stats_table_ = new StatsTable(statsfile, 20, 200);
- StatsTable::set_current(stats_table_);
}
virtual void Shutdown() {
@@ -124,10 +116,6 @@ class ChromeTestSuite : public TestSuite {
delete g_browser_process;
g_browser_process = NULL;
- // Tear down shared StatsTable; prevents unit_tests from leaking it.
- StatsTable::set_current(NULL);
- delete stats_table_;
-
// Delete the test_user_data dir recursively
FilePath user_data_dir;
if (PathService::Get(chrome::DIR_USER_DATA, &user_data_dir) &&
@@ -138,7 +126,6 @@ class ChromeTestSuite : public TestSuite {
TestSuite::Shutdown();
}
- StatsTable* stats_table_;
ScopedOleInitializer ole_initializer_;
scoped_refptr<WarningHostMapper> host_mapper_;
net::ScopedHostMapper scoped_host_mapper_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698