Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 1137243005: Add declaration for DictionaryValue in devtools_http_handler.h (Closed)

Created:
5 years, 7 months ago by mrunal
Modified:
5 years, 7 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, aandrey+blink_chromium.org, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add declaration for DictionaryValue in devtools_http_handler.h Without above change it breaks the build for Crosswalk which is dependent on content and components like devtools_http_handler. This is somehow not evident on Chrome or Content Shell builds which might be including base/values.h through some other includes. R=pfeldman@chromium.org BUG= Committed: https://crrev.com/eb8ea8d2984b4177cb7bc055efd0fd10859317fe Cr-Commit-Position: refs/heads/master@{#330581}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/devtools_http_handler/devtools_http_handler.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pfeldman
lgtm
5 years, 7 months ago (2015-05-19 03:56:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137243005/1
5 years, 7 months ago (2015-05-19 17:56:32 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 19:25:05 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 19:25:49 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/eb8ea8d2984b4177cb7bc055efd0fd10859317fe
Cr-Commit-Position: refs/heads/master@{#330581}

Powered by Google App Engine
This is Rietveld 408576698