Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 1137233002: Merge to XFA: Make (and verify) public/ files compile under C. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Make (and verify) public/ files compile under C. The following files needed adjustment beyond a mechanical merge: fpdfsdk/src/fpdfview.cpp public/fpdf_formfill.h samples/pdfium_test.cc testing/embedder_test.cpp Original Review URL: https://codereview.chromium.org/1130843003 BUG=pdfium:158 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/cf22eb8ac24d944aac08d6a17c12b8a3a602c6f5

Patch Set 1 #

Patch Set 2 : Test new XFA APIs. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -36 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M fpdfsdk/src/fpdfview.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
A fpdfsdk/src/fpdfview_c_api_test.h View 1 chunk +20 lines, -0 lines 0 comments Download
A fpdfsdk/src/fpdfview_c_api_test.c View 1 1 chunk +232 lines, -0 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 8 chunks +19 lines, -14 lines 0 comments Download
M pdfium.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M public/fpdf_dataavail.h View 1 chunk +1 line, -1 line 0 comments Download
M public/fpdf_ext.h View 1 chunk +2 lines, -2 lines 0 comments Download
M public/fpdf_formfill.h View 1 chunk +1 line, -1 line 0 comments Download
M public/fpdf_fwlevent.h View 2 chunks +8 lines, -0 lines 0 comments Download
M public/fpdf_save.h View 2 chunks +3 lines, -3 lines 0 comments Download
M public/fpdf_transformpage.h View 2 chunks +8 lines, -0 lines 0 comments Download
M public/fpdfview.h View 2 chunks +2 lines, -2 lines 0 comments Download
M samples/pdfium_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M testing/embedder_test.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tom Sepez
Lei, Not TBR'd, needs add'l review.
5 years, 7 months ago (2015-05-12 23:30:28 UTC) #1
Lei Zhang
The list in fpdfview_c_api_test.c needs to be updated, right?
5 years, 7 months ago (2015-05-13 00:09:06 UTC) #2
Tom Sepez
On 2015/05/13 00:09:06, Lei Zhang wrote: > The list in fpdfview_c_api_test.c needs to be updated, ...
5 years, 7 months ago (2015-05-13 00:26:44 UTC) #3
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-13 00:27:34 UTC) #4
Tom Sepez
5 years, 7 months ago (2015-05-13 00:28:12 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cf22eb8ac24d944aac08d6a17c12b8a3a602c6f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698