Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Issue 1137223002: core_services: Move resource_provider to core_services. (Closed)

Created:
5 years, 7 months ago by Elliot Glaysher
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

core_services: Move resource_provider to core_services. This moves the resource provider into the main core service process, too, eliminating one of the processes. BUG=477435 Committed: https://crrev.com/b74eff813ab0708158022afc3b029aacd47cfaf6 Cr-Commit-Position: refs/heads/master@{#329706}

Patch Set 1 #

Patch Set 2 : I have no idea what files I'm editing. #

Patch Set 3 : Maybe fix android compile this time. #

Total comments: 1

Patch Set 4 : Android stuff for sky #

Patch Set 5 : Add namespace #

Patch Set 6 : Also add imports. #

Patch Set 7 : Syntax error. #

Patch Set 8 : Remove data_dep per discussion with sky #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -14 lines) Patch
M components/html_viewer/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -4 lines 0 comments Download
M components/resource_provider/BUILD.gn View 1 2 5 chunks +3 lines, -6 lines 0 comments Download
M components/resource_provider/android/android_hooks.cc View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M components/resource_provider/android/java/org/chromium/resource_provider/Main.java View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M mandoline/app/android/BUILD.gn View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M mandoline/app/core_services_initialization.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M mandoline/services/core_services/BUILD.gn View 3 chunks +3 lines, -0 lines 0 comments Download
M mandoline/services/core_services/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/services/core_services/android_hooks.cc View 1 2 3 4 3 chunks +5 lines, -0 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Elliot Glaysher
5 years, 7 months ago (2015-05-13 00:04:00 UTC) #2
sky
You also need to update copy_mandoline_assets in mandoline/app/android/BUILD.gn and remove resource_provider.mojo from the list of ...
5 years, 7 months ago (2015-05-13 15:05:27 UTC) #3
sky
One more. https://codereview.chromium.org/1137223002/diff/40001/mandoline/services/core_services/android_hooks.cc File mandoline/services/core_services/android_hooks.cc (right): https://codereview.chromium.org/1137223002/diff/40001/mandoline/services/core_services/android_hooks.cc#newcode50 mandoline/services/core_services/android_hooks.cc:50: Java_Main_init(env, base::android::GetApplicationContext()); Main was ok in the ...
5 years, 7 months ago (2015-05-13 15:09:04 UTC) #4
Elliot Glaysher
ptal (I couldn't find a DEPS rule that referred to the resource_provider.)
5 years, 7 months ago (2015-05-13 18:17:29 UTC) #5
sky
LGTM
5 years, 7 months ago (2015-05-13 19:54:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137223002/140001
5 years, 7 months ago (2015-05-13 19:55:52 UTC) #9
commit-bot: I haz the power
Committed patchset #8 (id:140001)
5 years, 7 months ago (2015-05-13 20:23:32 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 20:24:29 UTC) #11
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/b74eff813ab0708158022afc3b029aacd47cfaf6
Cr-Commit-Position: refs/heads/master@{#329706}

Powered by Google App Engine
This is Rietveld 408576698