Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 1137183005: Remove DynamicSocketDataProvider (Closed)

Created:
5 years, 7 months ago by Ryan Hamilton
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DynamicSocketDataProvider only has one consumer, FtpSocketDataProvider. This CL moves the functionality of DynamicSocketDataProvider directly into FtpSocketDataProvider. Committed: https://crrev.com/faa1928d9a39bffd16f5fe48c308accbb3a26b01 Cr-Commit-Position: refs/heads/master@{#330317}

Patch Set 1 #

Patch Set 2 : Inline DynamicSocketDataProvider into FtpSocketDataProvider #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -75 lines) Patch
M net/ftp/ftp_network_transaction_unittest.cc View 1 6 chunks +47 lines, -4 lines 0 comments Download
M net/socket/socket_test_util.h View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 2 1 chunk +0 lines, -33 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Ryan Hamilton
Patch set 1 simply moves DynamicSocketDataProvider to ftp_network_transaction_unittest.cc. Patch set 2 inlines the functionality into ...
5 years, 7 months ago (2015-05-17 19:54:27 UTC) #3
ramant (doing other things)
lgtm
5 years, 7 months ago (2015-05-17 22:50:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137183005/60001
5 years, 7 months ago (2015-05-17 23:15:29 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 7 months ago (2015-05-18 00:17:10 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:33:11 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/faa1928d9a39bffd16f5fe48c308accbb3a26b01
Cr-Commit-Position: refs/heads/master@{#330317}

Powered by Google App Engine
This is Rietveld 408576698