Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 1137183003: Initialize Cast Media for cast_media_unittests (Closed)

Created:
5 years, 7 months ago by halliwell
Modified:
5 years, 7 months ago
Reviewers:
erickung1, gunsch
CC:
chromium-reviews, feature-media-reviews_chromium.org, lcwu+watch_chromium.org, gunsch+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Initialize Cast Media for cast_media_unittests This allows removal of the lazy initialisation workaround recently added to vendor media implementation. BUG= Committed: https://crrev.com/82c38ab5d0988f1bf46cecf7ab0a4affa670cd2e Cr-Commit-Position: refs/heads/master@{#330136}

Patch Set 1 #

Patch Set 2 : Comment update on CastMediaShlib #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M chromecast/media/cma/backend/audio_video_pipeline_device_unittest.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M chromecast/public/cast_media_shlib.h View 1 1 chunk +14 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
halliwell
5 years, 7 months ago (2015-05-15 04:41:33 UTC) #2
gunsch-google
On 2015/05/15 04:41:33, halliwell wrote: Don't mention specific vendors in commit messages.
5 years, 7 months ago (2015-05-15 06:19:39 UTC) #3
halliwell
On 2015/05/15 06:19:39, gunsch-google wrote: > On 2015/05/15 04:41:33, halliwell wrote: > > Don't mention ...
5 years, 7 months ago (2015-05-15 14:04:00 UTC) #4
gunsch
lgtm
5 years, 7 months ago (2015-05-15 16:29:11 UTC) #5
gunsch
Actually, on second thought---why not put this in chromecast/media/cma/run_all_unittests.cc instead?
5 years, 7 months ago (2015-05-15 16:29:51 UTC) #6
halliwell
On 2015/05/15 16:29:51, gunsch wrote: > Actually, on second thought---why not put this in > ...
5 years, 7 months ago (2015-05-15 16:49:58 UTC) #7
gunsch
discussed offline, but this lgtm % a comment in the public API documenting that we ...
5 years, 7 months ago (2015-05-15 17:00:11 UTC) #8
halliwell
On 2015/05/15 17:00:11, gunsch wrote: > discussed offline, but this lgtm % a comment in ...
5 years, 7 months ago (2015-05-15 17:38:35 UTC) #9
erickung1
On 2015/05/15 17:38:35, halliwell wrote: > On 2015/05/15 17:00:11, gunsch wrote: > > discussed offline, ...
5 years, 7 months ago (2015-05-15 17:45:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137183003/20001
5 years, 7 months ago (2015-05-15 18:06:51 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-15 18:20:35 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 18:21:22 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/82c38ab5d0988f1bf46cecf7ab0a4affa670cd2e
Cr-Commit-Position: refs/heads/master@{#330136}

Powered by Google App Engine
This is Rietveld 408576698