Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 1137153003: Implement direction-specific touch-action values. (Closed)

Created:
5 years, 7 months ago by dtapuska
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement direction-specific touch-action values. Now that change https://codereview.chromium.org/1137483003/ has landed fix up change (https://codereview.chromium.org/1131093002/) by removing the #if 0 and static casts. This change doesn't provide an implementation of touch-action because it has previously landed. But it activates the code paths because now pan-left/pan-right/pan-up/pan-down are passed transformed correctly between the blink and content APIs. BUG=476556 TEST=content_unittests Committed: https://crrev.com/f4c8e2abff40c85ff5ed0ff4baa1055e8c1dcf3e Cr-Commit-Position: refs/heads/master@{#330525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M content/renderer/render_widget.cc View 2 chunks +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
dtapuska
Sorry for the delay; the DEPS roller bot was pretty much stuck yesterday.
5 years, 7 months ago (2015-05-12 15:28:37 UTC) #2
Rick Byers
LGTM Please update the CL description/summary to make it clear that this CL is just ...
5 years, 7 months ago (2015-05-13 21:30:06 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-19 10:55:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137153003/1
5 years, 7 months ago (2015-05-19 13:28:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 16:59:59 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 17:01:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4c8e2abff40c85ff5ed0ff4baa1055e8c1dcf3e
Cr-Commit-Position: refs/heads/master@{#330525}

Powered by Google App Engine
This is Rietveld 408576698