Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1137103003: Move content:: scheme registrations from chrome/ to content/. (Closed)

Created:
5 years, 7 months ago by Mike West
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move content:: scheme registrations from chrome/ to content/. Both 'chrome:' and 'chrome-devtools:' are content-level schemes; we should do their various renderer-side scheme registrations in content (RenderThreadImpl::RegisterSchemes) rather than in chrome (ChromeContentRendererClient::RenderThreadStarted). R=jochen@chromium.org Committed: https://crrev.com/dcd7aad11d33ffd6dffe440ce32a0228c0843a67 Cr-Commit-Position: refs/heads/master@{#330506}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -18 lines) Patch
M chrome/renderer/chrome_content_renderer_client.cc View 3 chunks +6 lines, -16 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +13 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Mike West
As briefly discussed in https://codereview.chromium.org/809153004/, these scheme registrations would be better done in content than ...
5 years, 7 months ago (2015-05-19 08:03:40 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-19 11:24:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137103003/1
5 years, 7 months ago (2015-05-19 11:49:44 UTC) #5
philipj_slow
Thanks for keeping us in the loop. In general, the more that lives in content ...
5 years, 7 months ago (2015-05-19 11:53:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 11:53:57 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/dcd7aad11d33ffd6dffe440ce32a0228c0843a67 Cr-Commit-Position: refs/heads/master@{#330506}
5 years, 7 months ago (2015-05-19 11:54:50 UTC) #8
hiroshige
This CL caused Layout Test failures: https://crbug.com/489672. This is because WebSecurityPolicy::registerURLSchemeAsCORSEnabled(chrome_scheme); is called in content_shell. ...
5 years, 7 months ago (2015-05-19 13:06:37 UTC) #9
hiroshige
5 years, 7 months ago (2015-05-19 13:22:33 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1142213002/ by hiroshige@chromium.org.

The reason for reverting is: Breaks some layout tests

BUG=489672.

Powered by Google App Engine
This is Rietveld 408576698