Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 11371003: app_list: Add sync animation. (Closed)

Created:
8 years, 1 month ago by xiyuan
Modified:
8 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

app_list: Add sync animation. - Add a status property to AppListModel to indicate app syncing status; - Update this status when AppSyncUIState changes; - AppsGridView to hold AppListModel instead of just apps; - AppsGridView to show pulsing blocks on remaining slots on the last page when AppListModel status is syncing; BUG=129236 TEST=Verify app list showing pulsing white blocks for new user on cros. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166452

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix missed init #

Unified diffs Side-by-side diffs Delta from patch set Stats (+390 lines, -36 lines) Patch
M chrome/browser/ui/app_list/app_list_view_delegate.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_view_delegate.cc View 2 chunks +10 lines, -0 lines 0 comments Download
A chrome/browser/ui/ash/app_list/app_sync_ui_state_watcher.h View 1 chunk +36 lines, -0 lines 0 comments Download
A chrome/browser/ui/ash/app_list/app_sync_ui_state_watcher.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/app_list/app_list.gyp View 2 chunks +3 lines, -0 lines 0 comments Download
M ui/app_list/app_list_model.h View 3 chunks +16 lines, -0 lines 0 comments Download
M ui/app_list/app_list_model.cc View 1 2 chunks +21 lines, -1 line 0 comments Download
A ui/app_list/app_list_model_observer.h View 1 chunk +23 lines, -0 lines 0 comments Download
M ui/app_list/apps_grid_view.h View 6 chunks +15 lines, -3 lines 0 comments Download
M ui/app_list/apps_grid_view.cc View 13 chunks +61 lines, -15 lines 0 comments Download
M ui/app_list/apps_grid_view_unittest.cc View 12 chunks +18 lines, -16 lines 0 comments Download
M ui/app_list/contents_view.cc View 1 chunk +1 line, -1 line 0 comments Download
A ui/app_list/pulsing_block_view.h View 1 chunk +40 lines, -0 lines 0 comments Download
A ui/app_list/pulsing_block_view.cc View 1 chunk +106 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
xiyuan
8 years, 1 month ago (2012-11-06 21:57:43 UTC) #1
sky
https://codereview.chromium.org/11371003/diff/1/ui/app_list/app_list_model.cc File ui/app_list/app_list_model.cc (right): https://codereview.chromium.org/11371003/diff/1/ui/app_list/app_list_model.cc#newcode17 ui/app_list/app_list_model.cc:17: results_(new SearchResults) { Initialize status_ ?
8 years, 1 month ago (2012-11-07 00:22:30 UTC) #2
xiyuan
http://codereview.chromium.org/11371003/diff/1/ui/app_list/app_list_model.cc File ui/app_list/app_list_model.cc (right): http://codereview.chromium.org/11371003/diff/1/ui/app_list/app_list_model.cc#newcode17 ui/app_list/app_list_model.cc:17: results_(new SearchResults) { On 2012/11/07 00:22:30, sky wrote: > ...
8 years, 1 month ago (2012-11-07 00:56:02 UTC) #3
sky
LGTM
8 years, 1 month ago (2012-11-07 04:52:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/11371003/5001
8 years, 1 month ago (2012-11-07 14:56:40 UTC) #5
commit-bot: I haz the power
8 years, 1 month ago (2012-11-07 16:53:06 UTC) #6
Change committed as 166452

Powered by Google App Engine
This is Rietveld 408576698