Mac: Add more trace events for CAOpenGLLayers

Mac: Add more trace events for CAOpenGLLayers

There exists lots of tracing for the old CAOpenGLLayer path in
ui::IOSurfaceLayerHelper. The new path doesn't have this tracing.

This adds tracing for the swap state (this is the pseudo-thread
counter corresponding to PendingSwapAck in ui::IOSurfaceLayerHelper,
along with trace events for the important functions related to swaps
on Mac.

BUG=487882
Committed: https://crrev.com/7ecbfa316b3434fd0db181beefacc068e41d158b
Cr-Commit-Position: refs/heads/master@{#329878}

[ccameron, 2015-05-14 01:23:13]

ccameron@chromium.org changed reviewers:
+ erikchen@chromium.org

[ccameron, 2015-05-14 01:23:14]

More logs. Will be helpful with battor tracing, too.

[erikchen, 2015-05-14 01:43:53]

https://codereview.chromium.org/1137093003/diff/1/content/common/gpu/image_tr...
File content/common/gpu/image_transport_surface_calayer_mac.mm (right):

https://codereview.chromium.org/1137093003/diff/1/content/common/gpu/image_tr...
content/common/gpu/image_transport_surface_calayer_mac.mm:305: //
canDrawInCGLContext for other value meanings.
This comment is out of date.

https://codereview.chromium.org/1137093003/diff/1/content/common/gpu/image_tr...
content/common/gpu/image_transport_surface_calayer_mac.mm:446:
TRACE_COUNTER_ID1("gpu", "CALayerPendingSwap", this, 3);
Why is this not an instantaneous blip? When I look at the code in
"ui/accelerated_widget_mac/io_surface_layer.mm", which appears to be where you
mostly copied the comments/formatting of this tracing from, it immediately drops
back down to 2/0.

[ccameron, 2015-05-14 01:55:12]

Good point -- updated.

https://codereview.chromium.org/1137093003/diff/1/content/common/gpu/image_tr...
File content/common/gpu/image_transport_surface_calayer_mac.mm (right):

https://codereview.chromium.org/1137093003/diff/1/content/common/gpu/image_tr...
content/common/gpu/image_transport_surface_calayer_mac.mm:305: //
canDrawInCGLContext for other value meanings.
On 2015/05/14 01:43:53, erikchen wrote:
> This comment is out of date.

Oops. Changed to LayerCanDraw.

https://codereview.chromium.org/1137093003/diff/1/content/common/gpu/image_tr...
content/common/gpu/image_transport_surface_calayer_mac.mm:446:
TRACE_COUNTER_ID1("gpu", "CALayerPendingSwap", this, 3);
On 2015/05/14 01:43:53, erikchen wrote:
> Why is this not an instantaneous blip? When I look at the code in
> "ui/accelerated_widget_mac/io_surface_layer.mm", which appears to be where you
> mostly copied the comments/formatting of this tracing from, it immediately
drops
> back down to 2/0.

I didn't feel that having a blip was helpful. It won't be the case that you get
multiple LayerCanDraw calls (a blip would suggest that). It's also useful to see
the "can have draw and draw is ready" as a separate state (it's a very brief
state).

I changed the IOSurface code to do it this way.

[erikchen, 2015-05-14 16:04:09]

lgtm

https://codereview.chromium.org/1137093003/diff/40001/content/common/gpu/imag...
File content/common/gpu/image_transport_surface_calayer_mac.mm (right):

https://codereview.chromium.org/1137093003/diff/40001/content/common/gpu/imag...
content/common/gpu/image_transport_surface_calayer_mac.mm:442: // This would
tracing would be more natural to do with a pseudo-thread
grammar

[ccameron, 2015-05-14 17:20:14]

Thanks!

https://codereview.chromium.org/1137093003/diff/40001/content/common/gpu/imag...
File content/common/gpu/image_transport_surface_calayer_mac.mm (right):

https://codereview.chromium.org/1137093003/diff/40001/content/common/gpu/imag...
content/common/gpu/image_transport_surface_calayer_mac.mm:442: // This would
tracing would be more natural to do with a pseudo-thread
On 2015/05/14 16:04:08, erikchen wrote:
> grammar

Done.

[ccameron, 2015-05-14 17:20:15]

Thanks!

[ccameron, 2015-05-14 17:20:19]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2015-05-14 17:20:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
erikchen@chromium.org
Link to the patchset: https://codereview.chromium.org/1137093003/#ps60001
(title: "Fix grammar")

[commit-bot: I haz the power, 2015-05-14 17:20:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1137093003/60001

[commit-bot: I haz the power, 2015-05-14 18:07:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-05-14 18:08:58]

Patchset 4 (id:??) landed as
https://crrev.com/7ecbfa316b3434fd0db181beefacc068e41d158b
Cr-Commit-Position: refs/heads/master@{#329878}