Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1137083005: Move ContentBrowserSanityChecker and WebContentsObserverSanityChecker from content/public/test to c… (Closed)

Created:
5 years, 7 months ago by ncarter (slow)
Modified:
5 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move ContentBrowserSanityChecker and WebContentsObserverSanityChecker from content/public/test to content/test TEST=compiles BUG=None Committed: https://crrev.com/91476732a935bbd26036a6f3779a4946c4978ddc Cr-Commit-Position: refs/heads/master@{#329958}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -455 lines) Patch
M content/content_tests.gypi View 5 chunks +5 lines, -5 lines 0 comments Download
M content/public/test/browser_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/public/test/content_browser_sanity_checker.h View 1 chunk +0 lines, -42 lines 0 comments Download
D content/public/test/content_browser_sanity_checker.cc View 1 chunk +0 lines, -39 lines 0 comments Download
M content/public/test/test_renderer_host.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/public/test/web_contents_observer_sanity_checker.h View 1 chunk +0 lines, -101 lines 0 comments Download
D content/public/test/web_contents_observer_sanity_checker.cc View 1 chunk +0 lines, -257 lines 0 comments Download
A + content/test/content_browser_sanity_checker.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/test/content_browser_sanity_checker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + content/test/web_contents_observer_sanity_checker.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/test/web_contents_observer_sanity_checker.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
ncarter (slow)
jam, here you go
5 years, 7 months ago (2015-05-14 06:33:49 UTC) #2
jam
lgtm, thanks
5 years, 7 months ago (2015-05-14 21:49:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137083005/1
5 years, 7 months ago (2015-05-14 21:53:24 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 22:37:43 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 22:39:32 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/91476732a935bbd26036a6f3779a4946c4978ddc
Cr-Commit-Position: refs/heads/master@{#329958}

Powered by Google App Engine
This is Rietveld 408576698