Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1137083002: Revert of bluetooth: Android adapter can be created with and without Bluetooth permission. (Closed)

Created:
5 years, 7 months ago by jbudorick
Modified:
5 years, 7 months ago
Reviewers:
Ted C, scheib, armansito
CC:
chromium-reviews, klundberg+watch_chromium.org, scheib+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, ortuno
Base URL:
https://chromium.googlesource.com/chromium/src.git@bta-jni-
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of bluetooth: Android adapter can be created with and without Bluetooth permission. (patchset #2 id:110001 of https://codereview.chromium.org/1129683002/) Reason for revert: Failing on the main waterfall: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27824 Original issue's description: > bluetooth: Android adapter can be created with and without Bluetooth permission. > > This enables unit tests to run with Bluetooth permission, > by adding the Bluetooth permission to native_test. > > Non-test applications will not have the Bluetooth permission, > and unit tests should also verify behavior > when the permission is not given. To enable this > createWithoutPermissionForTesting is added and > results in a state equivalent to when the permission > is not available. > > Unit tests will be built in parallel for both when Bluetooth > permission exists and doesn't. > > BUG=471536 > > Committed: https://crrev.com/30e81472dc168ea1c331a8779b3f6a14f684c54b > Cr-Commit-Position: refs/heads/master@{#329212} TBR=tedchoc@chromium.org,armansito@chromium.org,scheib@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=471536 Committed: https://crrev.com/a0d2b2a7f02711370134f5083505a514e962a4c9 Cr-Commit-Position: refs/heads/master@{#329240}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -132 lines) Patch
M device/bluetooth/android/java/src/org/chromium/device/bluetooth/BluetoothAdapter.java View 3 chunks +6 lines, -71 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_android.h View 1 chunk +0 lines, -4 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_android.cc View 8 chunks +12 lines, -25 lines 0 comments Download
M device/bluetooth/bluetooth_adapter_android_unittest.cc View 1 chunk +1 line, -30 lines 0 comments Download
M testing/android/native_test/java/AndroidManifest.xml View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbudorick
Created Revert of bluetooth: Android adapter can be created with and without Bluetooth permission.
5 years, 7 months ago (2015-05-11 21:36:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137083002/1
5 years, 7 months ago (2015-05-11 21:39:07 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 21:41:47 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 21:43:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a0d2b2a7f02711370134f5083505a514e962a4c9
Cr-Commit-Position: refs/heads/master@{#329240}

Powered by Google App Engine
This is Rietveld 408576698