Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1137073006: Plugin Power Saver: Fix PDF interaction with Enterprise ASK policy. (Closed)

Created:
5 years, 7 months ago by tommycli
Modified:
5 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Fix PDF interaction with Enterprise ASK policy. Currently, on users with the ASK enterprise policy, viewing PDFs requires two right-click acknowledgements. This is broken. BUG=484247 Committed: https://crrev.com/f0555a5ec99af0661cc23591cedf378b63d19cce Cr-Commit-Position: refs/heads/master@{#329640}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix an error in the code (tests caught it) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M chrome/browser/plugins/plugin_info_message_filter.cc View 1 2 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137073006/20001
5 years, 7 months ago (2015-05-12 18:22:33 UTC) #2
tommycli
bauerb: PTAL small review. Would like to merge to 43 btw.
5 years, 7 months ago (2015-05-12 18:22:48 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/17037)
5 years, 7 months ago (2015-05-12 19:14:40 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137073006/40001
5 years, 7 months ago (2015-05-13 00:28:14 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-13 01:23:55 UTC) #10
Bernhard Bauer
lgtm
5 years, 7 months ago (2015-05-13 08:06:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137073006/40001
5 years, 7 months ago (2015-05-13 15:39:28 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-13 15:43:55 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 15:44:33 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/f0555a5ec99af0661cc23591cedf378b63d19cce
Cr-Commit-Position: refs/heads/master@{#329640}

Powered by Google App Engine
This is Rietveld 408576698