Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5888)

Unified Diff: chrome/browser/io_thread_unittest.cc

Issue 1137073003: Add a new disable_insecure_quic finch parameter to disable insecure QUIC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: cleanup Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/io_thread_unittest.cc
diff --git a/chrome/browser/io_thread_unittest.cc b/chrome/browser/io_thread_unittest.cc
index 08053b51172f02f9983ab735ee95dbac53953f71..de1d28643a2db83bfe238a7efeaf626d62e8d886 100644
--- a/chrome/browser/io_thread_unittest.cc
+++ b/chrome/browser/io_thread_unittest.cc
@@ -200,6 +200,7 @@ TEST_F(IOThreadTest, EnableQuicFromFieldTrialGroup) {
net::HttpNetworkSession::Params params;
InitializeNetworkSessionParams(&params);
EXPECT_TRUE(params.enable_quic);
+ EXPECT_FALSE(params.disable_insecure_quic);
EXPECT_TRUE(params.enable_quic_for_proxies);
EXPECT_EQ(1350u, params.quic_max_packet_length);
EXPECT_EQ(1.0, params.alternative_service_probability_threshold);
@@ -254,6 +255,15 @@ TEST_F(IOThreadTest, EnablePacingFromCommandLine) {
options.push_back(net::kPACE);
EXPECT_EQ(options, params.quic_connection_options);
}
+TEST_F(IOThreadTest, DisableInsecureQuicFromFieldTrialParams) {
+ field_trial_group_ = "Enabled";
+ field_trial_params_["disable_insecure_quic"] = "true";
+
+ ConfigureQuicGlobals();
+ net::HttpNetworkSession::Params params;
+ InitializeNetworkSessionParams(&params);
+ EXPECT_TRUE(params.disable_insecure_quic);
+}
TEST_F(IOThreadTest, EnablePacingFromFieldTrialParams) {
field_trial_group_ = "Enabled";

Powered by Google App Engine
This is Rietveld 408576698