Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 1137073003: Add a new disable_insecure_quic finch parameter to disable insecure QUIC. (Closed)

Created:
5 years, 7 months ago by Ryan Hamilton
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a new disable_insecure_quic finch parameter to disable insecure QUIC. Committed: https://crrev.com/405ed7a88665ab878556df117abcd02552c86d4c Cr-Commit-Position: refs/heads/master@{#329306}

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : fix comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -0 lines) Patch
M chrome/browser/io_thread.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/io_thread.cc View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/io_thread_unittest.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_network_session.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_stream_factory_impl.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Ryan Hamilton
As discussed in our recent team meeting.
5 years, 7 months ago (2015-05-11 22:11:07 UTC) #2
ramant (doing other things)
lgtm https://codereview.chromium.org/1137073003/diff/20001/chrome/browser/io_thread.h File chrome/browser/io_thread.h (right): https://codereview.chromium.org/1137073003/diff/20001/chrome/browser/io_thread.h#newcode337 chrome/browser/io_thread.h:337: // Returns true if QUIC should be enabled, ...
5 years, 7 months ago (2015-05-11 22:15:47 UTC) #3
Ryan Hamilton
https://codereview.chromium.org/1137073003/diff/20001/chrome/browser/io_thread.h File chrome/browser/io_thread.h (right): https://codereview.chromium.org/1137073003/diff/20001/chrome/browser/io_thread.h#newcode337 chrome/browser/io_thread.h:337: // Returns true if QUIC should be enabled, as ...
5 years, 7 months ago (2015-05-12 00:00:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137073003/40001
5 years, 7 months ago (2015-05-12 00:01:14 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-12 01:10:23 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 01:12:10 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/405ed7a88665ab878556df117abcd02552c86d4c
Cr-Commit-Position: refs/heads/master@{#329306}

Powered by Google App Engine
This is Rietveld 408576698