Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1137063002: Convert date_time_page to 0.8. (Closed)

Created:
5 years, 7 months ago by Kyle Horimoto
Modified:
5 years, 7 months ago
CC:
chromium-reviews, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert date_time_page to 0.8. While I was at it, I also added the page title as a translated string, as this seems to have been forgotten in the first implementation. Committed: https://crrev.com/c1134634b53b9dab5428ff3064accbb12373c013 Cr-Commit-Position: refs/heads/master@{#329274}

Patch Set 1 #

Patch Set 2 : Escape ampersand in XML file. #

Total comments: 8

Patch Set 3 : jlklein comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -75 lines) Patch
M chrome/app/settings_strings.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download
A + chrome/browser/resources/settings/date_time_page/date_time_page.css View 1 2 1 chunk +5 lines, -10 lines 0 comments Download
M chrome/browser/resources/settings/date_time_page/date_time_page.html View 1 2 1 chunk +10 lines, -15 lines 0 comments Download
M chrome/browser/resources/settings/date_time_page/date_time_page.js View 1 2 1 chunk +29 lines, -32 lines 0 comments Download
D chrome/browser/resources/settings/date_time_page/date_time_page_style.html View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Kyle Horimoto
Hopefully this looks good. Difficult to figure out if I did this correctly since we ...
5 years, 7 months ago (2015-05-11 19:05:12 UTC) #2
Jeremy Klein
https://codereview.chromium.org/1137063002/diff/20001/chrome/browser/resources/settings/date_time_page/date_time_page.css File chrome/browser/resources/settings/date_time_page/date_time_page.css (right): https://codereview.chromium.org/1137063002/diff/20001/chrome/browser/resources/settings/date_time_page/date_time_page.css#newcode5 chrome/browser/resources/settings/date_time_page/date_time_page.css:5: core-label { core-label doesn't exist in 0.8. What should ...
5 years, 7 months ago (2015-05-11 21:20:48 UTC) #3
Kyle Horimoto
+jhakwins for: chrome/app/settings_strings.grdp chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc https://codereview.chromium.org/1137063002/diff/20001/chrome/browser/resources/settings/date_time_page/date_time_page.css File chrome/browser/resources/settings/date_time_page/date_time_page.css (right): https://codereview.chromium.org/1137063002/diff/20001/chrome/browser/resources/settings/date_time_page/date_time_page.css#newcode5 chrome/browser/resources/settings/date_time_page/date_time_page.css:5: core-label { On 2015/05/11 21:20:48, ...
5 years, 7 months ago (2015-05-11 21:34:58 UTC) #5
Jeremy Klein
lgtm
5 years, 7 months ago (2015-05-11 21:36:39 UTC) #6
James Hawkins
lgtm
5 years, 7 months ago (2015-05-11 21:38:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137063002/40001
5 years, 7 months ago (2015-05-11 21:41:39 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-11 23:44:39 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 23:45:27 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c1134634b53b9dab5428ff3064accbb12373c013
Cr-Commit-Position: refs/heads/master@{#329274}

Powered by Google App Engine
This is Rietveld 408576698