Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 1137053003: [Ozone-Drm] Use synchronous page flips with the DRM platform (Closed)

Created:
5 years, 7 months ago by dnicoara
Modified:
5 years, 7 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-Drm] Use synchronous page flips with the DRM platform The DRM platform doesn't support asynchronous page flips. BUG=none Committed: https://crrev.com/8425e22d93f5214af30d7353b6a1a2c46b4c7d64 Cr-Commit-Position: refs/heads/master@{#329401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/ozone/platform/drm/gpu/drm_surface.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (4 generated)
dnicoara
5 years, 7 months ago (2015-05-11 21:20:12 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137053003/1
5 years, 7 months ago (2015-05-11 21:23:56 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-11 21:48:47 UTC) #6
spang
lgtm
5 years, 7 months ago (2015-05-11 22:23:23 UTC) #7
spang
On 2015/05/11 22:23:23, spang wrote: > lgtm Hm, could we snapshot the canvas & flip ...
5 years, 7 months ago (2015-05-11 22:24:50 UTC) #8
dnicoara
On 2015/05/11 22:24:50, spang wrote: > On 2015/05/11 22:23:23, spang wrote: > > lgtm > ...
5 years, 7 months ago (2015-05-12 14:08:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1137053003/1
5 years, 7 months ago (2015-05-12 14:08:54 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 14:12:17 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/8425e22d93f5214af30d7353b6a1a2c46b4c7d64 Cr-Commit-Position: refs/heads/master@{#329401}
5 years, 7 months ago (2015-05-12 14:13:02 UTC) #13
spang
5 years, 7 months ago (2015-05-12 14:32:27 UTC) #14
Message was sent while issue was closed.
On 2015/05/12 14:08:22, dnicoara wrote:
> On 2015/05/11 22:24:50, spang wrote:
> > On 2015/05/11 22:23:23, spang wrote:
> > > lgtm
> > 
> > Hm, could we snapshot the canvas & flip asynchronously?
> > 
> > It seems like the sync flip path should be deprecated, if possible.
> 
> We could. For now this is done synchronously for simplicity.
> 
> The sync flip is still used in the video_decode_accelerator_unittest (Not sure
> if there are other targets using this). We'll need to convert that first if we
> want to get rid of the synchronous flips.

Yeah, I think we should get rid of both uses.

Powered by Google App Engine
This is Rietveld 408576698