Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1137033005: Moterm part 6: Add moterm_example_app. (Closed)

Created:
5 years, 7 months ago by viettrungluu
Modified:
5 years, 7 months ago
Reviewers:
Elliot Glaysher
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Moterm part 6: Add moterm_example_app. This is an example app that is itself embeddable, and in turn embeds a single moterm. It uses that moterm to prompt the user about what to connect to (e.g.: mojo:echo_terminal, mojo:netcat?host=localhost&port=80), and then connects the moterm to whatever the user enters. After that connection is done (typically terminated by ^D on a line by itself), it prompts the user again, etc. R=erg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/70d849d9e0a9f4fe5ae6dc8751ddd92df0ce66fd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+228 lines, -0 lines) Patch
M apps/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M apps/moterm/BUILD.gn View 1 chunk +19 lines, -0 lines 0 comments Download
A apps/moterm/moterm_example_app.cc View 1 chunk +208 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
5 years, 7 months ago (2015-05-11 23:17:10 UTC) #1
Elliot Glaysher
lgtm
5 years, 7 months ago (2015-05-11 23:47:45 UTC) #2
viettrungluu
5 years, 7 months ago (2015-05-11 23:57:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
70d849d9e0a9f4fe5ae6dc8751ddd92df0ce66fd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698